Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization in reference to consts.ts #97

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

sampsyo
Copy link
Contributor

@sampsyo sampsyo commented Apr 11, 2016

This matters on case-sensitive filesystems---that is, it arises on Linux but generally doesn't come up on Windows or OS X. On ext4 and othercase-sensitive filesystems, Node can't find consts.ts when it is referenced as Consts.

In particular, I got this error when running a bot on Linux:

module.js:341
    throw err;
    ^

Error: Cannot find module '../Consts'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> ([snip]/node_modules/botbuilder/lib/dialogs/DialogCollection.js:10:14)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)

This matters on case-sensitive filesystems---that is, it arises on Linux but
generally doesn't come up on Windows or OS X. On ext4 and other
case-sensitive filesystems, TypeScript and Node can't find `consts.ts` when it
is references as `Consts`.
@Stevenic Stevenic merged commit 434a9bf into microsoft:master Apr 12, 2016
@Stevenic
Copy link
Contributor

good catch,,,

@pandres95
Copy link

pandres95 commented May 22, 2016

Getting the same error. This is due linux-based systems often use case-sensitive filesystems, thus throwing this kind of errors.
Also, @sampsyo, this is not the only reference to ../consts that fails capitalization. The best solution –I guess– is to fully capitalize the name in the require, because it stands on Microsoft's code style.

@Stevenic
Copy link
Contributor

@pandres95 what file(s) are you seeing this with so I can fix them? I'm sorry. We test on windows machines so we miss stuff like this.

@pandres95
Copy link

pandres95 commented May 23, 2016

Actually, got an update to a newer version that fixes the issue.
Thanks a lot 😅

@Stevenic
Copy link
Contributor

Ok good... I just searched through all of the files and couldn't see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants