This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Web Test Harness] Pass the authenticated user ID into web chat & update UI #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e F5 stylesheet from Bot Builder samples.
Passing user id derived from authenticated user into web chat to demonstrate linked accounts functionality in web chat.
lauren-mills
approved these changes
Dec 19, 2018
darrenj
approved these changes
Dec 19, 2018
lauren-mills
pushed a commit
that referenced
this pull request
Apr 18, 2019
…ate UI (#472) * Updated UI for more consistent experience in customer demos, using the F5 stylesheet from Bot Builder samples. * Cleaned up styling to only use applicable classes in web test. Passing user id derived from authenticated user into web chat to demonstrate linked accounts functionality in web chat.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've updated the Web Test Harness to apply the fix microsoft/BotFramework-WebChat#1447, which allows the test harness to pass an authenticated user's id to the bot conversation. This enables linked accounts to be demoed in web chat.
Since the Web Test solution may be used in customer demos, I've also applied some skinning to the UI matching the CSS stylesheet provided by the "F5" page in the bot templates. This, along with some additional content, should better tell the story of using the test harness.
I've also added a "Copy" button to easily copy the user id to the clipboard. This will remove some minor friction for presenters.
Note: This still has an issue with the Onboarding Dialog, in that the
ConversationUpdateActivity via Direct Line uses theConversation.Idas theFrom.Idproperty. Subsequent messages to the bot use the provided user id.Related Issue
#470
#471
#473
Testing Steps
Run the Web Test solution with a working bot, link your account and then navigate to the web chat tab. In that conversation if you trigger a skill requiring authentication you should skip the bot asking for you to sign on.
Ping me and I can provide a working appsettings using the BFVirtualAssistant demo environment.
Checklist
If this contains changes that needs to be replicated between the Enterprise Template <-> Virtual Assistant