Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement admin components of az-isolated-service-single-region template. #194

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Implement admin components of az-isolated-service-single-region template. #194

merged 2 commits into from
Jul 1, 2019

Conversation

nmiodice
Copy link

@nmiodice nmiodice commented Jun 26, 2019

All Submissions:


  • [YES] Have you followed the guidelines in our Contributing document?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [NO] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.
  • [YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?


No template exists for az-isolated-service-single-region

Issue Number: #188

What is the new behavior?


az-isolated-service-single-region template partially implemented. The template should include the resources called out in the design that are deployed to subscription #1.

Does this introduce a breaking change?


  • [NO]

Any relevant logs, error output, etc?


  • 2 Deployed Apps w/ Staging Slots
    apps

  • App Service Plan deployed to ASE
    asp

Notes

  • There is a follow on PR to handle the scenario where Isolated app services can take > 1 hour to deploy

@nmiodice nmiodice marked this pull request as ready for review June 26, 2019 17:25
Copy link
Contributor

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🚀 Especially like how you're leveraging azurem providers to manage the multi-target subscriptions for this template.

…ate.

This change is scoped to the items called out in the design that live in
subscription 1.
@nmiodice nmiodice merged commit c558ed0 into microsoft:master Jul 1, 2019
@nmiodice nmiodice deleted the niiodice/features/az-isolated-service-single-region-sub-1 branch July 1, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants