-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement admin components of az-isolated-service-single-region template. #194
Merged
nmiodice
merged 2 commits into
microsoft:master
from
nmiodice:niiodice/features/az-isolated-service-single-region-sub-1
Jul 1, 2019
Merged
Implement admin components of az-isolated-service-single-region template. #194
nmiodice
merged 2 commits into
microsoft:master
from
nmiodice:niiodice/features/az-isolated-service-single-region-sub-1
Jul 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infra/templates/az-isolated-service-single-region/.env.template
Outdated
Show resolved
Hide resolved
erikschlegel
requested changes
Jun 28, 2019
infra/templates/az-isolated-service-single-region/tests/integration/integration_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 🚀 Especially like how you're leveraging azurem providers to manage the multi-target subscriptions for this template.
ianphil
approved these changes
Jun 28, 2019
infra/templates/az-isolated-service-single-region/tests/integration/integration_test.go
Show resolved
Hide resolved
infra/templates/az-isolated-service-single-region/tests/unit/unit_test.go
Show resolved
Hide resolved
…ate. This change is scoped to the items called out in the design that live in subscription 1.
erikschlegel
approved these changes
Jul 1, 2019
nmiodice
deleted the
niiodice/features/az-isolated-service-single-region-sub-1
branch
July 1, 2019 15:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
No template exists for
az-isolated-service-single-region
Issue Number: #188
What is the new behavior?
az-isolated-service-single-region
template partially implemented. The template should include the resources called out in the design that are deployed to subscription #1.Does this introduce a breaking change?
Any relevant logs, error output, etc?
2 Deployed Apps w/ Staging Slots
App Service Plan deployed to ASE
Notes
Isolated
app services can take > 1 hour to deploy