Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go CLI Replacement #1052

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Go CLI Replacement #1052

merged 6 commits into from
Apr 1, 2024

Conversation

amitla1
Copy link
Contributor

@amitla1 amitla1 commented Mar 28, 2024

Adding replacement module for the GO CLI scan not just fallback scan
#122

@amitla1 amitla1 requested a review from a team as a code owner March 28, 2024 04:59
@amitla1 amitla1 requested a review from JamieMagee March 28, 2024 04:59
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 75.6%. Comparing base (90a1031) to head (f0d6eb0).

Files Patch % Lines
...ion.Detectors/go/GoComponentWithReplaceDetector.cs 83.7% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1052     +/-   ##
=======================================
+ Coverage   72.9%   75.6%   +2.7%     
=======================================
  Files        239     239             
  Lines      10811   10821     +10     
  Branches    1085    1086      +1     
=======================================
+ Hits        7884    8188    +304     
+ Misses      2633    2321    -312     
- Partials     294     312     +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 29, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@amitla1 amitla1 merged commit 2de3cc0 into main Apr 1, 2024
26 checks passed
@amitla1 amitla1 deleted the users/avannikumar/goCLIReplacement branch April 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants