Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Go Replace Exceptions #1273

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

amitla1
Copy link
Contributor

@amitla1 amitla1 commented Oct 14, 2024

When trying to use the replace module if the replace module path goes to a private repository it can cause an error in this case use the original path and log the warning to users that way they know as they may need to action on their end to use replace modules

@amitla1 amitla1 requested a review from a team as a code owner October 14, 2024 19:24
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.1%. Comparing base (96cc922) to head (b3809eb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onentDetection.Detectors/go/GoComponentDetector.cs 40.0% 6 Missing ⚠️
...mmon/Telemetry/Records/GoReplaceTelemetryRecord.cs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1273     +/-   ##
=======================================
- Coverage   89.1%   89.1%   -0.1%     
=======================================
  Files        361     361             
  Lines      27733   27742      +9     
  Branches    1757    1757             
=======================================
+ Hits       24720   24722      +2     
- Misses      2636    2643      +7     
  Partials     377     377             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 14, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@amitla1 amitla1 merged commit ae28751 into main Oct 14, 2024
22 of 26 checks passed
@amitla1 amitla1 deleted the users/avannikumar/handleExceptions branch October 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants