Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Modern lifecycle + Ownership #1089

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

[WIP] Modern lifecycle + Ownership #1089

wants to merge 33 commits into from

Conversation

lalitb
Copy link
Contributor

@lalitb lalitb commented Jan 20, 2023

Ongoing PR, not yet for review.
Included changes

  • Deprecate shared global state (the LogManager instance that is not really an instance).
  • Return unique_ptr for ILogManager.

@@ -731,7 +731,7 @@ namespace MAT_NS_BEGIN
static ILogManager* GetInstance() noexcept
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to go as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really all the static methods

Copy link
Contributor Author

@lalitb lalitb Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am trying to see if we can make LogManager as instance of LogManagerBase instead of global static, and then make all these methods as non-static. Though LogConfiguration is still a concern here, as it is difficult to create deep copy of it (as it can contain void * as the config value).

@lalitb lalitb marked this pull request as ready for review March 16, 2023 03:50
@lalitb lalitb marked this pull request as draft March 16, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants