-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Modern lifecycle + Ownership #1089
base: main
Are you sure you want to change the base?
Conversation
…ry into v4-refactor
This reverts commit ad8dafd.
@@ -731,7 +731,7 @@ namespace MAT_NS_BEGIN | |||
static ILogManager* GetInstance() noexcept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to go as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really all the static methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am trying to see if we can make LogManager as instance of LogManagerBase instead of global static, and then make all these methods as non-static. Though LogConfiguration is still a concern here, as it is difficult to create deep copy of it (as it can contain void *
as the config value).
Ongoing PR, not yet for review.
Included changes