Fix #1337: Get port info from debugpy #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send "debugpySockets" event with information about opened sockets when clients connect and whenever ports get opened or closed.
|
Kudos, SonarCloud Quality Gate passed! |
AdamYoblick
approved these changes
Oct 5, 2023
| "port": port, | ||
| "internal": listener is not clients.listener, | ||
| } | ||
| for listener in [clients.listener, launchers.listener, servers.listener] |
There was a problem hiding this comment.
What's going on with the lack of indenting in this for loop?
There was a problem hiding this comment.
This is a Python list comprehension. C# equivalent would be something like:
from listener in ...
where listener is ...
let (host, port) = listener.getsockname()
select {...}
.ToList()| @@ -701,6 +702,24 @@ def disconnect_request(self, request): | |||
| def disconnect(self): | |||
| super().disconnect() | |||
|
|
|||
| def report_sockets(self): | |||
| sockets = [ | |||
There was a problem hiding this comment.
I'm not familiar with this list initialization syntax. Is there supposed to be a comma after the dict? Does the code afterwards resolve to a list and it gets stuffed into the sockets parent list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send "debugpySockets" event with information about opened sockets when clients connect and whenever ports get opened or closed.