update macos image. macos-11 is no longer supported. #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Jun 24, 2024
|
Ugh. Looks like moving up to macos-latest image broke something in the numpy tests. Need to troubleshoot. |
|
I just ran the debugpy-test pipeline from main to compare the results, and there are several test failures there too: https://dev.azure.com/debugpy/debugpy/_build/results?buildId=4174&view=ms.vss-test-web.build-test-results-tab I will compare the failures but I don't think moving up to macos-latest pool is the cause of any of these. If the failures are the same, I'm going to merge this in, since staying on macos-11 will definitely cause failures very soon. |
|
Yeah I'm going to merge this in. The same tests are failing when I run fresh from main. My changes has nothing to do with the breaks. I will investigate those test failures separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.