Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::filesystem usage with std::filesystem #169

Merged
merged 11 commits into from
Mar 23, 2023

Conversation

shishirb-MSFT
Copy link
Contributor

  • Always wanted to move to the C++17 filesystem implementation. What prompted the change now: The FindBoost issue on Ubuntu 20.04 involving symlinking /lib to /usr/lib but /include being non-existent.
  • This change removes public dependency on Boost libs entirely, leaving only the tests using boost.program_options. So, our cmake config file will no longer have to deal with the paths for boost.
  • GCC 8, which is the default at least on Ubuntu 18.04, requires use of std::experimental::filesystem. Code has been changed appropriately to support building with both flavors of filesystem.

@shishirb-MSFT shishirb-MSFT requested a review from a team as a code owner March 23, 2023 15:30
Copy link
Contributor

@JeffreySaathoff JeffreySaathoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shishirb-MSFT shishirb-MSFT merged commit 211cfce into develop Mar 23, 2023
@shishirb-MSFT shishirb-MSFT deleted the user/shishirb/replace-boostfs-stdfs branch March 23, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants