This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Cache Version and FrameworkName in json deserialization #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
changed the title
Lxiamail
reviewed
Jul 11, 2019
| _factory = factory; | ||
| } | ||
|
|
||
| public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
| { | ||
| var value = serializer.Deserialize<JToken>(reader).ToString(); | ||
|
|
||
| return string.IsNullOrEmpty(value) ? default(T) : _factory(value); | ||
| return string.IsNullOrEmpty(value) ? default : _cache.GetOrAdd(value, _factory); |
There was a problem hiding this comment.
we still want "default(T)" instead of "default", right?
There was a problem hiding this comment.
default is the literal keyword in C# 7.1 for default(T)
https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-7-1#default-literal-expressions
conniey
approved these changes
Jul 11, 2019
Lxiamail
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converter is used to create Version and FrameworkName instances which are a small set of known values in the assembly. This caches them so that we can reuse them when creating them.