Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the COMPLUS_NGenProtectedProcess_FeatureEnabled variable where it is not necessary #231

Open
MichaelSimons opened this issue Mar 11, 2019 · 5 comments

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Mar 11, 2019

Remove COMPLUS_NGenProtectedProcess_FeatureEnabled variable where it is not necessary

https://microsoft.visualstudio.com/OS/_workitems/edit/14119988?fullScreen=false (Microsoft internal only link) says that it should be fixed: “We've made changes to the base images in RS4 such that CI hint EAs are preserved. This should allow the native images in the base images to be loaded.”.

When fixing, please double check by timing of tiny test powershell script.

@mthalman
Copy link
Member

mthalman commented Sep 4, 2019

Blocked by https://microsoft.visualstudio.com/OS/_workitems/edit/23107258/ (internal MSFT link)

@olljanat
Copy link

Btw. What COMPLUS_NGenProtectedProcess_FeatureEnabled = 0 actually does?

I noticed that I have copied ngen update logic with this settings to our server template creating process but now I started to think about if that does make any sense or not on Win Srv 2019 and/or Win Srv 2022?

@mthalman
Copy link
Member

Blocked by https://microsoft.visualstudio.com/OS/_workitems/edit/23107258/ (internal MSFT link)

This is resolved now as the issue no longer repros.

@MichaelSimons
Copy link
Member Author

This is resolved now as the issue no longer repros.

Is this something we can fix in servicing or do we want to wait for a new version? If we can fix this now, we should consider moving it to the current sprint.

@mthalman
Copy link
Member

Since it would involve the removal of an environment variable, I think it would be safest to do this as part of a new Windows release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants