Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COMPLUS_NGenProtectedProcess_FeatureEnabled env var #307

Closed
wants to merge 1 commit into from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Jul 1, 2019

The need to set the COMPLUS_NGenProtectedProcess_FeatureEnabled environment variable in order to run ngen in a container has been removed due to an update made in the Windows base images starting in RS4. The runtime Dockerfiles have been updated to remove the setting of this variable. The only runtime Dockerfiles that are left unchanged are for 2016 LTSC.

Fixes #231

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelSimons
Copy link
Member

I assume this won't be merged into master until the next the next .NET patch cycle?

@mthalman
Copy link
Member Author

mthalman commented Jul 2, 2019

I assume this won't be merged into master until the next the next .NET patch cycle?

Correct

@mthalman
Copy link
Member Author

mthalman commented Jul 2, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mthalman
Copy link
Member Author

mthalman commented Sep 4, 2019

Abandoning this PR since it's blocked by https://microsoft.visualstudio.com/OS/_workitems/edit/23107258/ (internal MSFT link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the COMPLUS_NGenProtectedProcess_FeatureEnabled variable where it is not necessary
2 participants