fix: update ci daily and ci weekly for consistency #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibrahimmaga
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
robarbms
approved these changes
May 14, 2021
chrisdholt
approved these changes
May 14, 2021
…y-for-consistency
awentzel
approved these changes
May 14, 2021
Ibrahimmaga
deleted the
users/v-imaga/Update-Ci-daily-and-Ci-weakly-for-consistency
branch
This was referenced Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
update ci daily and ci weekly for consistency
📖 Description
On both ci-daily and ci-weekly, this PR will insure the Prettier check run before the yarn prepare execute. Yarn prepare takes time to execute. If a prettier check fails, the CI will automatically fail, then we do not need to spend time running yarn prepare.
🎫 Issues
#4636
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps