Feat: Support "Grouped" Menu Items #6729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
scomea
reviewed
May 11, 2023
| "comment": "Feat: support grouped menu-items", | ||
| "packageName": "@microsoft/fast-foundation", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" |
scomea
reviewed
May 11, 2023
| * check if the item is a grouped menu item | ||
| */ | ||
| protected isGroupedMenuItemElement = (el: Element): el is HTMLElement => { | ||
| return (el.getAttribute("role") as string) === "group"; |
There was a problem hiding this comment.
Do you need to cast to string?
|
Closing this, due to #6951 we are only putting in fixes or critical features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds support for grouping menu-items.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps