Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whatInput): Type event listeners #20024

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Sep 29, 2021

Pull request checklist

Description of changes

Adds the WhatInputEvents to type event listeners with the events that
can be used by what-input

Focus areas to test

(optional)

Adds the `WhatInputEvents` to type event listeners with the events that
can be used by what-input
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca8432d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 29, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e4b81fbb0b65fe3483ce0f9ce5d88c6c7b7ac9b5 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 29, 2021

📊 Bundle size report

🤖 This report was generated against e4b81fbb0b65fe3483ce0f9ce5d88c6c7b7ac9b5

@ling1726 ling1726 enabled auto-merge (squash) September 29, 2021 09:03
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1072 1120 5000
BaseButton mount 1038 1065 5000
Breadcrumb mount 2805 2795 1000
ButtonNext mount 526 514 5000
Checkbox mount 1759 1780 5000
CheckboxBase mount 1515 1519 5000
ChoiceGroup mount 5423 5430 5000
ComboBox mount 1087 1050 1000
CommandBar mount 11020 10924 1000
ContextualMenu mount 7020 7003 1000
DefaultButton mount 1274 1312 5000
DetailsRow mount 4225 4220 5000
DetailsRowFast mount 4091 4133 5000
DetailsRowNoStyles mount 3907 3992 5000
Dialog mount 2672 2681 1000
DocumentCardTitle mount 163 174 1000
Dropdown mount 3542 3608 5000
FluentProviderNext mount 7421 7370 5000
FluentProviderWithTheme mount 341 361 10
FluentProviderWithTheme virtual-rerender 105 97 10
FluentProviderWithTheme virtual-rerender-with-unmount 409 419 10
FocusTrapZone mount 2003 2012 5000
FocusZone mount 1956 1978 5000
IconButton mount 1995 2209 5000
Label mount 373 371 5000
Layer mount 3287 3295 5000
Link mount 541 549 5000
MakeStyles mount 1965 1979 50000
MenuButton mount 1632 1671 5000
MessageBar mount 2213 2182 5000
Nav mount 3781 3736 1000
OverflowSet mount 1219 1199 5000
Panel mount 2587 2522 1000
Persona mount 966 941 1000
Pivot mount 1574 1562 1000
PrimaryButton mount 1470 1471 5000
Rating mount 8839 8926 5000
SearchBox mount 1557 1522 5000
Shimmer mount 2901 2956 5000
Slider mount 2189 2177 5000
SpinButton mount 5552 5562 5000
Spinner mount 460 452 5000
SplitButton mount 3521 3514 5000
Stack mount 555 566 5000
StackWithIntrinsicChildren mount 2040 2073 5000
StackWithTextChildren mount 5462 5468 5000
SwatchColorPicker mount 11714 11601 5000
Tabs mount 1545 1562 1000
TagPicker mount 2992 2985 5000
TeachingBubble mount 13788 13708 5000
Text mount 490 483 5000
TextField mount 1546 1555 5000
ThemeProvider mount 1275 1304 5000
ThemeProvider virtual-rerender 642 633 5000
ThemeProvider virtual-rerender-with-unmount 2062 2057 5000
Toggle mount 908 911 5000
buttonNative mount 130 132 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 283 249 1.14:1
AttachmentMinimalPerf.default 199 183 1.09:1
RadioGroupMinimalPerf.default 543 500 1.09:1
ButtonMinimalPerf.default 220 204 1.08:1
TableMinimalPerf.default 486 448 1.08:1
FlexMinimalPerf.default 346 322 1.07:1
AnimationMinimalPerf.default 481 455 1.06:1
TreeWith60ListItems.default 217 204 1.06:1
CarouselMinimalPerf.default 557 533 1.05:1
DividerMinimalPerf.default 424 405 1.05:1
GridMinimalPerf.default 404 383 1.05:1
HeaderMinimalPerf.default 418 400 1.05:1
PortalMinimalPerf.default 206 196 1.05:1
InputMinimalPerf.default 1481 1424 1.04:1
ListMinimalPerf.default 605 584 1.04:1
AlertMinimalPerf.default 329 318 1.03:1
AvatarMinimalPerf.default 235 229 1.03:1
DialogMinimalPerf.default 864 835 1.03:1
FormMinimalPerf.default 491 478 1.03:1
HeaderSlotsPerf.default 899 876 1.03:1
ImageMinimalPerf.default 449 437 1.03:1
ItemLayoutMinimalPerf.default 1430 1388 1.03:1
MenuMinimalPerf.default 989 958 1.03:1
ProviderMinimalPerf.default 1357 1312 1.03:1
IconMinimalPerf.default 738 717 1.03:1
TextAreaMinimalPerf.default 639 620 1.03:1
TreeMinimalPerf.default 914 884 1.03:1
ButtonOverridesMissPerf.default 2035 1994 1.02:1
ChatDuplicateMessagesPerf.default 353 346 1.02:1
LoaderMinimalPerf.default 783 766 1.02:1
ToolbarMinimalPerf.default 1102 1085 1.02:1
VideoMinimalPerf.default 720 707 1.02:1
AttachmentSlotsPerf.default 1244 1235 1.01:1
BoxMinimalPerf.default 393 388 1.01:1
CardMinimalPerf.default 649 641 1.01:1
ChatWithPopoverPerf.default 441 436 1.01:1
DatepickerMinimalPerf.default 6140 6097 1.01:1
LayoutMinimalPerf.default 429 423 1.01:1
ListWith60ListItems.default 763 755 1.01:1
MenuButtonMinimalPerf.default 1870 1860 1.01:1
SegmentMinimalPerf.default 395 393 1.01:1
SplitButtonMinimalPerf.default 4820 4766 1.01:1
TableManyItemsPerf.default 2210 2180 1.01:1
CustomToolbarPrototype.default 4543 4520 1.01:1
TooltipMinimalPerf.default 1197 1182 1.01:1
ChatMinimalPerf.default 757 757 1:1
CheckboxMinimalPerf.default 3015 3007 1:1
DropdownManyItemsPerf.default 816 817 1:1
DropdownMinimalPerf.default 3447 3445 1:1
EmbedMinimalPerf.default 4779 4786 1:1
LabelMinimalPerf.default 451 452 1:1
ListCommonPerf.default 729 730 1:1
SliderMinimalPerf.default 1925 1916 1:1
TextMinimalPerf.default 402 401 1:1
AccordionMinimalPerf.default 176 177 0.99:1
ButtonSlotsPerf.default 644 648 0.99:1
ProviderMergeThemesPerf.default 1849 1877 0.99:1
SkeletonMinimalPerf.default 411 414 0.99:1
StatusMinimalPerf.default 776 780 0.99:1
ReactionMinimalPerf.default 445 456 0.98:1
ListNestedPerf.default 645 662 0.97:1
RosterPerf.default 1358 1397 0.97:1
PopupMinimalPerf.default 630 648 0.97:1

@ling1726 ling1726 merged commit 586adc8 into microsoft:master Sep 29, 2021
@ling1726 ling1726 mentioned this pull request Sep 29, 2021
1 task
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* fix(whatInput): Type event listeners

Adds the `WhatInputEvents` to type event listeners with the events that
can be used by what-input

* changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants