Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-accordion: Adjust signature to use ForwardRefComponent #20080

Merged
merged 2 commits into from
Oct 4, 2021
Merged

react-accordion: Adjust signature to use ForwardRefComponent #20080

merged 2 commits into from
Oct 4, 2021

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@bsunderhus bsunderhus requested a review from a team as a code owner October 4, 2021 09:18
@bsunderhus bsunderhus self-assigned this Oct 4, 2021
@bsunderhus bsunderhus mentioned this pull request Oct 4, 2021
Closed
18 tasks
@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 55.059 kB
17.394 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB
🤖 This report was generated against d66bbf48477efc7bb108336436b89144a5093f99

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e587a37:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d66bbf48477efc7bb108336436b89144a5093f99 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Panel mount 2007 2795 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 799 820 5000
BaseButton mount 804 802 5000
Breadcrumb mount 2454 2478 1000
ButtonNext mount 431 441 5000
Checkbox mount 1295 1352 5000
CheckboxBase mount 1169 1138 5000
ChoiceGroup mount 4127 4075 5000
ComboBox mount 882 842 1000
CommandBar mount 9565 9309 1000
ContextualMenu mount 5912 5887 1000
DefaultButton mount 1000 1001 5000
DetailsRow mount 3394 3408 5000
DetailsRowFast mount 3323 3309 5000
DetailsRowNoStyles mount 3205 3248 5000
Dialog mount 2253 2156 1000
DocumentCardTitle mount 159 172 1000
Dropdown mount 2853 2874 5000
FluentProviderNext mount 3144 3071 5000
FluentProviderWithTheme mount 179 170 10
FluentProviderWithTheme virtual-rerender 90 98 10
FluentProviderWithTheme virtual-rerender-with-unmount 201 204 10
FocusTrapZone mount 1622 1582 5000
FocusZone mount 1571 1589 5000
IconButton mount 1533 1497 5000
Label mount 321 310 5000
Layer mount 2583 2587 5000
Link mount 426 445 5000
MakeStyles mount 1612 1593 50000
MenuButton mount 1322 1273 5000
MessageBar mount 1866 1800 5000
Nav mount 2870 2842 1000
OverflowSet mount 997 979 5000
Panel mount 2007 2795 1000 Possible regression
Persona mount 747 760 1000
Pivot mount 1237 1217 1000
PrimaryButton mount 1120 1105 5000
Rating mount 6587 6596 5000
SearchBox mount 1131 1141 5000
Shimmer mount 2164 2186 5000
Slider mount 1673 1675 5000
SpinButton mount 4302 4275 5000
Spinner mount 383 377 5000
SplitButton mount 2706 2665 5000
Stack mount 433 439 5000
StackWithIntrinsicChildren mount 1473 1565 5000
StackWithTextChildren mount 3940 3935 5000
SwatchColorPicker mount 9366 9082 5000
Tabs mount 1341 1270 1000
TagPicker mount 2429 2653 5000
TeachingBubble mount 11244 11317 5000
Text mount 372 391 5000
TextField mount 1236 1211 5000
ThemeProvider mount 1039 1062 5000
ThemeProvider virtual-rerender 536 533 5000
ThemeProvider virtual-rerender-with-unmount 1618 1613 5000
Toggle mount 715 736 5000
buttonNative mount 137 122 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CustomToolbarPrototype.default 5638 3800 1.48:1
AvatarMinimalPerf.default 195 161 1.21:1
AttachmentMinimalPerf.default 147 132 1.11:1
SkeletonMinimalPerf.default 340 309 1.1:1
TreeWith60ListItems.default 166 153 1.08:1
FormMinimalPerf.default 349 328 1.06:1
RefMinimalPerf.default 208 197 1.06:1
SegmentMinimalPerf.default 314 297 1.06:1
PopupMinimalPerf.default 523 500 1.05:1
StatusMinimalPerf.default 597 568 1.05:1
IconMinimalPerf.default 555 528 1.05:1
TableMinimalPerf.default 370 351 1.05:1
DividerMinimalPerf.default 314 301 1.04:1
MenuMinimalPerf.default 750 722 1.04:1
RadioGroupMinimalPerf.default 387 371 1.04:1
ChatWithPopoverPerf.default 331 321 1.03:1
LabelMinimalPerf.default 337 326 1.03:1
SliderMinimalPerf.default 1504 1458 1.03:1
TextMinimalPerf.default 324 315 1.03:1
ToolbarMinimalPerf.default 844 820 1.03:1
AttachmentSlotsPerf.default 929 912 1.02:1
ButtonSlotsPerf.default 480 469 1.02:1
DropdownManyItemsPerf.default 588 575 1.02:1
GridMinimalPerf.default 294 288 1.02:1
HeaderMinimalPerf.default 311 306 1.02:1
LayoutMinimalPerf.default 317 311 1.02:1
ProviderMinimalPerf.default 1033 1009 1.02:1
TooltipMinimalPerf.default 920 906 1.02:1
ButtonMinimalPerf.default 148 146 1.01:1
CardMinimalPerf.default 472 469 1.01:1
ChatDuplicateMessagesPerf.default 264 262 1.01:1
DatepickerMinimalPerf.default 4736 4701 1.01:1
ImageMinimalPerf.default 315 312 1.01:1
ItemLayoutMinimalPerf.default 1031 1020 1.01:1
ListWith60ListItems.default 562 557 1.01:1
SplitButtonMinimalPerf.default 3799 3761 1.01:1
TextAreaMinimalPerf.default 449 446 1.01:1
AlertMinimalPerf.default 234 234 1:1
ButtonOverridesMissPerf.default 1529 1530 1:1
ChatMinimalPerf.default 548 547 1:1
CheckboxMinimalPerf.default 2340 2340 1:1
DialogMinimalPerf.default 632 631 1:1
DropdownMinimalPerf.default 2726 2726 1:1
InputMinimalPerf.default 1122 1123 1:1
ListMinimalPerf.default 433 431 1:1
TableManyItemsPerf.default 1697 1696 1:1
VideoMinimalPerf.default 526 525 1:1
BoxMinimalPerf.default 283 287 0.99:1
CarouselMinimalPerf.default 396 398 0.99:1
EmbedMinimalPerf.default 3620 3653 0.99:1
FlexMinimalPerf.default 249 251 0.99:1
HeaderSlotsPerf.default 632 641 0.99:1
PortalMinimalPerf.default 155 156 0.99:1
ProviderMergeThemesPerf.default 1493 1502 0.99:1
AccordionMinimalPerf.default 133 136 0.98:1
ReactionMinimalPerf.default 319 326 0.98:1
TreeMinimalPerf.default 703 715 0.98:1
AnimationMinimalPerf.default 346 357 0.97:1
ListNestedPerf.default 467 488 0.96:1
LoaderMinimalPerf.default 600 622 0.96:1
MenuButtonMinimalPerf.default 1385 1438 0.96:1
RosterPerf.default 997 1058 0.94:1
ListCommonPerf.default 528 568 0.93:1

@bsunderhus bsunderhus merged commit a3391fb into microsoft:master Oct 4, 2021
@bsunderhus bsunderhus deleted the react-accordion-forwardrefcomponent branch October 4, 2021 09:58
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@bsunderhus
react-accordion: Adjust signature to use ForwardRefComponent (microso…
ab224ba 
…ft#20080)

* Adds ForwardRefComponent to components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavstastny miroslavstastny miroslavstastny approved these changes

Assignees

@bsunderhus bsunderhus

Labels
Component: Accordion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsunderhus @fabricteam @miroslavstastny