Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-divider: Adjust signature to use ForwardRefComponent #20084

Merged

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme
32.188 kB
10.658 kB
react-divider
Divider
15.342 kB
5.585 kB
🤖 This report was generated against a3391fbf4643431624961121002c512b130a1126

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c568f6f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1067 1060 5000
BaseButton mount 1082 1079 5000
Breadcrumb mount 2829 2808 1000
ButtonNext mount 554 542 5000
Checkbox mount 1764 1809 5000
CheckboxBase mount 1526 1497 5000
ChoiceGroup mount 5442 5449 5000
ComboBox mount 1102 1065 1000
CommandBar mount 10912 10863 1000
ContextualMenu mount 7013 7017 1000
DefaultButton mount 1355 1303 5000
DetailsRow mount 4297 4518 5000
DetailsRowFast mount 4232 4465 5000
DetailsRowNoStyles mount 4047 4001 5000
Dialog mount 2592 2627 1000
DocumentCardTitle mount 183 194 1000
Dropdown mount 3594 3596 5000
FluentProviderNext mount 3477 3454 5000
FluentProviderWithTheme mount 212 232 10
FluentProviderWithTheme virtual-rerender 106 108 10
FluentProviderWithTheme virtual-rerender-with-unmount 248 238 10
FocusTrapZone mount 1962 1966 5000
FocusZone mount 1977 1931 5000
IconButton mount 2006 1988 5000
Label mount 381 385 5000
Layer mount 3221 3307 5000
Link mount 543 537 5000
MakeStyles mount 1944 1964 50000
MenuButton mount 1730 1662 5000
MessageBar mount 2163 2161 5000
Nav mount 4182 3677 1000
OverflowSet mount 1260 1237 5000
Panel mount 2495 2470 1000
Persona mount 931 939 1000
Pivot mount 1602 1589 1000
PrimaryButton mount 1494 1461 5000
Rating mount 8816 8801 5000
SearchBox mount 1580 1587 5000
Shimmer mount 2874 2953 5000
Slider mount 2212 2168 5000
SpinButton mount 5603 5566 5000
Spinner mount 471 464 5000
SplitButton mount 3511 3493 5000
Stack mount 577 615 5000
StackWithIntrinsicChildren mount 2013 2049 5000
StackWithTextChildren mount 5589 5438 5000
SwatchColorPicker mount 12566 11565 5000
Tabs mount 1593 1561 1000
TagPicker mount 3018 2959 5000
TeachingBubble mount 13777 13730 5000
Text mount 496 487 5000
TextField mount 1618 1554 5000
ThemeProvider mount 1278 1267 5000
ThemeProvider virtual-rerender 663 634 5000
ThemeProvider virtual-rerender-with-unmount 2112 2109 5000
Toggle mount 925 942 5000
buttonNative mount 148 148 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 392 325 1.21:1
AlertMinimalPerf.default 343 298 1.15:1
StatusMinimalPerf.default 866 755 1.15:1
ButtonMinimalPerf.default 216 191 1.13:1
AnimationMinimalPerf.default 492 441 1.12:1
ListMinimalPerf.default 623 562 1.11:1
HeaderSlotsPerf.default 920 834 1.1:1
RefMinimalPerf.default 263 240 1.1:1
ChatMinimalPerf.default 781 719 1.09:1
RadioGroupMinimalPerf.default 529 495 1.07:1
AvatarMinimalPerf.default 230 218 1.06:1
AccordionMinimalPerf.default 176 167 1.05:1
FormMinimalPerf.default 504 479 1.05:1
LabelMinimalPerf.default 446 425 1.05:1
LayoutMinimalPerf.default 408 390 1.05:1
ListWith60ListItems.default 767 729 1.05:1
PortalMinimalPerf.default 190 181 1.05:1
ButtonSlotsPerf.default 638 616 1.04:1
ChatWithPopoverPerf.default 437 421 1.04:1
HeaderMinimalPerf.default 423 406 1.04:1
SegmentMinimalPerf.default 401 385 1.04:1
SplitButtonMinimalPerf.default 4841 4664 1.04:1
CardMinimalPerf.default 650 631 1.03:1
DividerMinimalPerf.default 406 393 1.03:1
GridMinimalPerf.default 387 374 1.03:1
ListNestedPerf.default 646 629 1.03:1
TableMinimalPerf.default 469 455 1.03:1
BoxMinimalPerf.default 383 376 1.02:1
MenuMinimalPerf.default 959 940 1.02:1
CustomToolbarPrototype.default 4440 4361 1.02:1
CheckboxMinimalPerf.default 2990 2953 1.01:1
DropdownManyItemsPerf.default 807 797 1.01:1
DropdownMinimalPerf.default 3377 3338 1.01:1
FlexMinimalPerf.default 325 321 1.01:1
LoaderMinimalPerf.default 743 735 1.01:1
PopupMinimalPerf.default 627 620 1.01:1
SkeletonMinimalPerf.default 421 416 1.01:1
IconMinimalPerf.default 710 705 1.01:1
TooltipMinimalPerf.default 1157 1147 1.01:1
DatepickerMinimalPerf.default 6008 6014 1:1
DialogMinimalPerf.default 824 826 1:1
EmbedMinimalPerf.default 4763 4769 1:1
ImageMinimalPerf.default 447 448 1:1
ItemLayoutMinimalPerf.default 1355 1352 1:1
ProviderMergeThemesPerf.default 1838 1831 1:1
SliderMinimalPerf.default 1853 1854 1:1
ToolbarMinimalPerf.default 1062 1063 1:1
AttachmentMinimalPerf.default 183 185 0.99:1
AttachmentSlotsPerf.default 1166 1180 0.99:1
ButtonOverridesMissPerf.default 1977 1990 0.99:1
ListCommonPerf.default 714 721 0.99:1
MenuButtonMinimalPerf.default 1813 1823 0.99:1
TableManyItemsPerf.default 2173 2196 0.99:1
CarouselMinimalPerf.default 524 532 0.98:1
RosterPerf.default 1357 1383 0.98:1
TextMinimalPerf.default 384 393 0.98:1
ReactionMinimalPerf.default 434 448 0.97:1
TextAreaMinimalPerf.default 599 616 0.97:1
TreeMinimalPerf.default 891 921 0.97:1
VideoMinimalPerf.default 688 712 0.97:1
InputMinimalPerf.default 1454 1517 0.96:1
ProviderMinimalPerf.default 1240 1285 0.96:1
TreeWith60ListItems.default 189 197 0.96:1

@bsunderhus bsunderhus merged commit 9e5eb4b into microsoft:master Oct 4, 2021
@bsunderhus bsunderhus deleted the react-divider-forwardrefcomponent branch October 4, 2021 20:12
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…#20084)

* Adds ForwardRefComponent to react-divider components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants