Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-menu: Adjust signature to use ForwardRefComponent #20087

Merged

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-button
Button
23.224 kB
7.219 kB
react-button
CompoundButton
28.481 kB
8.173 kB
react-button
MenuButton
25.249 kB
7.895 kB
react-button
SplitButton
30.737 kB
8.955 kB
react-button
ToggleButton
32.45 kB
7.868 kB
react-card
Card - All
13.471 kB
5.068 kB
react-card
Card
9.317 kB
3.925 kB
react-card
CardFooter
8.468 kB
3.557 kB
react-card
CardHeader
9.695 kB
3.99 kB
react-card
CardPreview
8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme
32.188 kB
10.658 kB
react-menu
Menu (including children components)
103.316 kB
31.501 kB
react-menu
Menu (including selectable components)
105.592 kB
31.866 kB
🤖 This report was generated against a3391fbf4643431624961121002c512b130a1126

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 944 981 5000
BaseButton mount 949 973 5000
Breadcrumb mount 2682 2706 1000
ButtonNext mount 516 507 5000
Checkbox mount 1560 1610 5000
CheckboxBase mount 1288 1376 5000
ChoiceGroup mount 4767 4850 5000
ComboBox mount 1017 1086 1000
CommandBar mount 10467 10550 1000
ContextualMenu mount 6591 6511 1000
DefaultButton mount 1148 1192 5000
DetailsRow mount 3844 3863 5000
DetailsRowFast mount 3917 3872 5000
DetailsRowNoStyles mount 3635 3688 5000
Dialog mount 2470 2531 1000
DocumentCardTitle mount 166 162 1000
Dropdown mount 3347 3427 5000
FluentProviderNext mount 3499 3459 5000
FluentProviderWithTheme mount 223 227 10
FluentProviderWithTheme virtual-rerender 107 106 10
FluentProviderWithTheme virtual-rerender-with-unmount 248 252 10
FocusTrapZone mount 1799 1910 5000
FocusZone mount 1894 1843 5000
IconButton mount 1766 1778 5000
Label mount 365 365 5000
Layer mount 3069 3000 5000
Link mount 500 522 5000
MakeStyles mount 1898 1866 50000
MenuButton mount 1516 1552 5000
MessageBar mount 2087 2164 5000
Nav mount 3298 3432 1000
OverflowSet mount 1159 1158 5000
Panel mount 2372 2422 1000
Persona mount 900 851 1000
Pivot mount 1481 1513 1000
PrimaryButton mount 1363 1338 5000
Rating mount 7842 7753 5000
SearchBox mount 1348 1420 5000
Shimmer mount 2650 2553 5000
Slider mount 1991 2034 5000
SpinButton mount 5077 5187 5000
Spinner mount 465 463 5000
SplitButton mount 3541 3229 5000
Stack mount 507 527 5000
StackWithIntrinsicChildren mount 1803 1784 5000
StackWithTextChildren mount 4865 4692 5000
SwatchColorPicker mount 10654 10629 5000
Tabs mount 1498 1493 1000
TagPicker mount 2662 2849 5000
TeachingBubble mount 13397 13343 5000
Text mount 446 446 5000
TextField mount 1398 1439 5000
ThemeProvider mount 1223 1230 5000
ThemeProvider virtual-rerender 617 650 5000
ThemeProvider virtual-rerender-with-unmount 1866 1941 5000
Toggle mount 844 828 5000
buttonNative mount 143 134 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 162 145 1.12:1
IconMinimalPerf.default 664 596 1.11:1
GridMinimalPerf.default 367 335 1.1:1
SegmentMinimalPerf.default 360 334 1.08:1
ChatMinimalPerf.default 703 658 1.07:1
FormMinimalPerf.default 415 391 1.06:1
RefMinimalPerf.default 257 242 1.06:1
AttachmentMinimalPerf.default 167 159 1.05:1
DividerMinimalPerf.default 364 346 1.05:1
PortalMinimalPerf.default 194 184 1.05:1
RadioGroupMinimalPerf.default 480 457 1.05:1
ReactionMinimalPerf.default 388 370 1.05:1
TableMinimalPerf.default 431 410 1.05:1
ChatWithPopoverPerf.default 403 388 1.04:1
InputMinimalPerf.default 1381 1330 1.04:1
ListWith60ListItems.default 682 656 1.04:1
LoaderMinimalPerf.default 731 700 1.04:1
StatusMinimalPerf.default 714 688 1.04:1
TreeMinimalPerf.default 842 810 1.04:1
TreeWith60ListItems.default 188 181 1.04:1
AlertMinimalPerf.default 275 266 1.03:1
ChatDuplicateMessagesPerf.default 309 300 1.03:1
DialogMinimalPerf.default 800 777 1.03:1
LabelMinimalPerf.default 397 384 1.03:1
MenuButtonMinimalPerf.default 1714 1670 1.03:1
PopupMinimalPerf.default 604 587 1.03:1
TextMinimalPerf.default 358 346 1.03:1
CheckboxMinimalPerf.default 2817 2775 1.02:1
DropdownMinimalPerf.default 3273 3201 1.02:1
HeaderMinimalPerf.default 368 362 1.02:1
HeaderSlotsPerf.default 774 756 1.02:1
TableManyItemsPerf.default 1944 1906 1.02:1
BoxMinimalPerf.default 355 353 1.01:1
ButtonMinimalPerf.default 183 181 1.01:1
ButtonOverridesMissPerf.default 1781 1771 1.01:1
ButtonSlotsPerf.default 584 576 1.01:1
RosterPerf.default 1168 1156 1.01:1
SkeletonMinimalPerf.default 354 352 1.01:1
SplitButtonMinimalPerf.default 4306 4281 1.01:1
CustomToolbarPrototype.default 4216 4192 1.01:1
TooltipMinimalPerf.default 1039 1032 1.01:1
AttachmentSlotsPerf.default 1084 1084 1:1
CarouselMinimalPerf.default 480 481 1:1
EmbedMinimalPerf.default 4342 4322 1:1
FlexMinimalPerf.default 303 303 1:1
ItemLayoutMinimalPerf.default 1240 1239 1:1
ListCommonPerf.default 639 636 1:1
MenuMinimalPerf.default 868 866 1:1
ProviderMinimalPerf.default 1149 1147 1:1
SliderMinimalPerf.default 1729 1735 1:1
TextAreaMinimalPerf.default 506 504 1:1
ToolbarMinimalPerf.default 964 970 0.99:1
AnimationMinimalPerf.default 429 440 0.98:1
CardMinimalPerf.default 543 553 0.98:1
DatepickerMinimalPerf.default 5528 5649 0.98:1
ProviderMergeThemesPerf.default 1756 1791 0.98:1
VideoMinimalPerf.default 625 637 0.98:1
AvatarMinimalPerf.default 197 205 0.96:1
ListNestedPerf.default 550 575 0.96:1
ImageMinimalPerf.default 369 387 0.95:1
LayoutMinimalPerf.default 359 378 0.95:1
DropdownManyItemsPerf.default 683 728 0.94:1
ListMinimalPerf.default 497 533 0.93:1

@layershifter layershifter merged commit b5ece82 into microsoft:master Oct 4, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
)

* Adds ForwardRefComponent to react-menu components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants