Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-popover: Adjust signature to use ForwardRefComponent #20088

Merged

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme
32.188 kB
10.658 kB
react-popover
Popover
101.153 kB
30.37 kB
🤖 This report was generated against a3391fbf4643431624961121002c512b130a1126

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 944 951 5000
BaseButton mount 923 945 5000
Breadcrumb mount 2686 2677 1000
ButtonNext mount 514 513 5000
Checkbox mount 1596 1579 5000
CheckboxBase mount 1310 1313 5000
ChoiceGroup mount 4872 4763 5000
ComboBox mount 998 998 1000
CommandBar mount 10301 10350 1000
ContextualMenu mount 6542 6559 1000
DefaultButton mount 1215 1207 5000
DetailsRow mount 3798 3787 5000
DetailsRowFast mount 3804 3873 5000
DetailsRowNoStyles mount 3779 3711 5000
Dialog mount 2568 2470 1000
DocumentCardTitle mount 171 181 1000
Dropdown mount 3393 3291 5000
FluentProviderNext mount 3393 3455 5000
FluentProviderWithTheme mount 208 203 10
FluentProviderWithTheme virtual-rerender 99 109 10
FluentProviderWithTheme virtual-rerender-with-unmount 250 257 10
FocusTrapZone mount 1803 1850 5000
FocusZone mount 1859 1820 5000
IconButton mount 1798 1798 5000
Label mount 355 359 5000
Layer mount 3080 3031 5000
Link mount 503 490 5000
MakeStyles mount 1851 1853 50000
MenuButton mount 1547 1510 5000
MessageBar mount 2043 2036 5000
Nav mount 3435 3334 1000
OverflowSet mount 1173 1154 5000
Panel mount 2430 2434 1000
Persona mount 875 858 1000
Pivot mount 1434 1461 1000
PrimaryButton mount 1304 1320 5000
Rating mount 7733 8023 5000
SearchBox mount 1359 1379 5000
Shimmer mount 2587 2540 5000
Slider mount 1986 2026 5000
SpinButton mount 5088 5109 5000
Spinner mount 437 439 5000
SplitButton mount 3269 3182 5000
Stack mount 519 546 5000
StackWithIntrinsicChildren mount 1717 1717 5000
StackWithTextChildren mount 4693 4706 5000
SwatchColorPicker mount 10583 10526 5000
Tabs mount 1482 1482 1000
TagPicker mount 2720 2695 5000
TeachingBubble mount 13227 13267 5000
Text mount 448 437 5000
TextField mount 1418 1461 5000
ThemeProvider mount 1223 1200 5000
ThemeProvider virtual-rerender 633 624 5000
ThemeProvider virtual-rerender-with-unmount 1943 1876 5000
Toggle mount 831 822 5000
buttonNative mount 157 142 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 167 144 1.16:1
PortalMinimalPerf.default 200 173 1.16:1
AttachmentMinimalPerf.default 176 154 1.14:1
ButtonMinimalPerf.default 188 171 1.1:1
ChatDuplicateMessagesPerf.default 322 298 1.08:1
LabelMinimalPerf.default 404 380 1.06:1
RefMinimalPerf.default 247 233 1.06:1
AvatarMinimalPerf.default 202 193 1.05:1
ButtonSlotsPerf.default 568 539 1.05:1
FlexMinimalPerf.default 301 287 1.05:1
AnimationMinimalPerf.default 426 408 1.04:1
HeaderMinimalPerf.default 365 352 1.04:1
ProviderMergeThemesPerf.default 1800 1738 1.04:1
GridMinimalPerf.default 348 339 1.03:1
ListMinimalPerf.default 523 510 1.03:1
MenuButtonMinimalPerf.default 1676 1631 1.03:1
SkeletonMinimalPerf.default 362 351 1.03:1
TableMinimalPerf.default 402 389 1.03:1
AttachmentSlotsPerf.default 1114 1096 1.02:1
DialogMinimalPerf.default 763 748 1.02:1
EmbedMinimalPerf.default 4347 4280 1.02:1
ItemLayoutMinimalPerf.default 1220 1195 1.02:1
ListNestedPerf.default 561 549 1.02:1
ListWith60ListItems.default 652 640 1.02:1
RadioGroupMinimalPerf.default 447 438 1.02:1
ToolbarMinimalPerf.default 945 928 1.02:1
ButtonOverridesMissPerf.default 1804 1786 1.01:1
DividerMinimalPerf.default 360 357 1.01:1
DropdownManyItemsPerf.default 687 677 1.01:1
DropdownMinimalPerf.default 3266 3236 1.01:1
InputMinimalPerf.default 1359 1346 1.01:1
MenuMinimalPerf.default 850 838 1.01:1
ReactionMinimalPerf.default 378 376 1.01:1
BoxMinimalPerf.default 341 342 1:1
CarouselMinimalPerf.default 493 492 1:1
DatepickerMinimalPerf.default 5567 5561 1:1
LoaderMinimalPerf.default 725 725 1:1
SplitButtonMinimalPerf.default 4286 4306 1:1
TextMinimalPerf.default 344 345 1:1
CustomToolbarPrototype.default 4182 4203 1:1
TreeMinimalPerf.default 807 805 1:1
CardMinimalPerf.default 551 554 0.99:1
ChatWithPopoverPerf.default 391 396 0.99:1
CheckboxMinimalPerf.default 2736 2766 0.99:1
ImageMinimalPerf.default 367 372 0.99:1
ProviderMinimalPerf.default 1113 1127 0.99:1
StatusMinimalPerf.default 672 680 0.99:1
IconMinimalPerf.default 610 618 0.99:1
TextAreaMinimalPerf.default 486 493 0.99:1
TooltipMinimalPerf.default 1022 1029 0.99:1
VideoMinimalPerf.default 621 629 0.99:1
HeaderSlotsPerf.default 761 773 0.98:1
ListCommonPerf.default 624 636 0.98:1
TableManyItemsPerf.default 1861 1893 0.98:1
AlertMinimalPerf.default 267 276 0.97:1
SliderMinimalPerf.default 1715 1759 0.97:1
PopupMinimalPerf.default 590 615 0.96:1
SegmentMinimalPerf.default 345 359 0.96:1
FormMinimalPerf.default 396 416 0.95:1
RosterPerf.default 1165 1227 0.95:1
TreeWith60ListItems.default 184 193 0.95:1
ChatMinimalPerf.default 652 701 0.93:1
LayoutMinimalPerf.default 361 388 0.93:1

@layershifter layershifter merged commit fe56e1a into microsoft:master Oct 4, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…#20088)

* Adds ForwardRefComponent to react-popover components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants