Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-card: Adjust signature to use ForwardRefComponent #20090

Merged

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
13.471 kB
5.068 kB
react-card
Card
9.317 kB
3.925 kB
react-card
CardFooter
8.468 kB
3.557 kB
react-card
CardHeader
9.695 kB
3.99 kB
react-card
CardPreview
8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme
32.188 kB
10.658 kB
🤖 This report was generated against a3391fbf4643431624961121002c512b130a1126

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 938 969 5000
BaseButton mount 938 968 5000
Breadcrumb mount 2715 2702 1000
ButtonNext mount 523 530 5000
Checkbox mount 1591 1630 5000
CheckboxBase mount 1327 1358 5000
ChoiceGroup mount 4725 5031 5000
ComboBox mount 1063 1008 1000
CommandBar mount 10492 10416 1000
ContextualMenu mount 6636 6669 1000
DefaultButton mount 1216 1173 5000
DetailsRow mount 3819 3893 5000
DetailsRowFast mount 3837 3871 5000
DetailsRowNoStyles mount 3775 3743 5000
Dialog mount 2588 2523 1000
DocumentCardTitle mount 153 176 1000
Dropdown mount 3343 3339 5000
FluentProviderNext mount 3458 3505 5000
FluentProviderWithTheme mount 216 226 10
FluentProviderWithTheme virtual-rerender 98 105 10
FluentProviderWithTheme virtual-rerender-with-unmount 241 246 10
FocusTrapZone mount 1851 1826 5000
FocusZone mount 1833 1876 5000
IconButton mount 1828 1851 5000
Label mount 360 376 5000
Layer mount 3011 3073 5000
Link mount 485 491 5000
MakeStyles mount 1873 1947 50000
MenuButton mount 1492 1566 5000
MessageBar mount 2065 2100 5000
Nav mount 3407 3347 1000
OverflowSet mount 1145 1136 5000
Panel mount 2436 2401 1000
Persona mount 877 889 1000
Pivot mount 1507 1448 1000
PrimaryButton mount 1349 1349 5000
Rating mount 7910 7961 5000
SearchBox mount 1424 1377 5000
Shimmer mount 2665 2624 5000
Slider mount 2038 2030 5000
SpinButton mount 5148 5231 5000
Spinner mount 454 456 5000
SplitButton mount 3289 3224 5000
Stack mount 524 535 5000
StackWithIntrinsicChildren mount 1775 1756 5000
StackWithTextChildren mount 4809 4822 5000
SwatchColorPicker mount 10669 10812 5000
Tabs mount 1506 1459 1000
TagPicker mount 2672 2702 5000
TeachingBubble mount 13361 13439 5000
Text mount 456 440 5000
TextField mount 1469 1444 5000
ThemeProvider mount 1230 1214 5000
ThemeProvider virtual-rerender 644 651 5000
ThemeProvider virtual-rerender-with-unmount 1934 1962 5000
Toggle mount 857 815 5000
buttonNative mount 133 136 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 180 156 1.15:1
AvatarMinimalPerf.default 209 195 1.07:1
FormMinimalPerf.default 427 400 1.07:1
ListCommonPerf.default 659 621 1.06:1
RadioGroupMinimalPerf.default 472 447 1.06:1
FlexMinimalPerf.default 293 280 1.05:1
LabelMinimalPerf.default 406 386 1.05:1
SegmentMinimalPerf.default 361 345 1.05:1
StatusMinimalPerf.default 693 662 1.05:1
VideoMinimalPerf.default 664 630 1.05:1
HeaderSlotsPerf.default 790 757 1.04:1
ImageMinimalPerf.default 385 369 1.04:1
RefMinimalPerf.default 257 248 1.04:1
ButtonMinimalPerf.default 184 178 1.03:1
CardMinimalPerf.default 572 558 1.03:1
GridMinimalPerf.default 355 345 1.03:1
HeaderMinimalPerf.default 366 357 1.03:1
MenuMinimalPerf.default 890 867 1.03:1
ToolbarMinimalPerf.default 979 949 1.03:1
ButtonOverridesMissPerf.default 1818 1790 1.02:1
ListNestedPerf.default 561 549 1.02:1
LoaderMinimalPerf.default 722 709 1.02:1
TableManyItemsPerf.default 1927 1890 1.02:1
TooltipMinimalPerf.default 1059 1040 1.02:1
AttachmentSlotsPerf.default 1098 1082 1.01:1
DialogMinimalPerf.default 770 764 1.01:1
EmbedMinimalPerf.default 4410 4368 1.01:1
InputMinimalPerf.default 1353 1340 1.01:1
LayoutMinimalPerf.default 377 373 1.01:1
ListMinimalPerf.default 520 515 1.01:1
MenuButtonMinimalPerf.default 1680 1659 1.01:1
PopupMinimalPerf.default 617 613 1.01:1
PortalMinimalPerf.default 183 181 1.01:1
ChatDuplicateMessagesPerf.default 296 295 1:1
ChatWithPopoverPerf.default 379 378 1:1
DropdownMinimalPerf.default 3240 3228 1:1
ListWith60ListItems.default 651 650 1:1
TableMinimalPerf.default 409 411 1:1
TextAreaMinimalPerf.default 502 504 1:1
CustomToolbarPrototype.default 4183 4194 1:1
TreeWith60ListItems.default 183 183 1:1
ChatMinimalPerf.default 646 653 0.99:1
CheckboxMinimalPerf.default 2805 2831 0.99:1
ReactionMinimalPerf.default 382 384 0.99:1
SliderMinimalPerf.default 1711 1725 0.99:1
SplitButtonMinimalPerf.default 4382 4406 0.99:1
TextMinimalPerf.default 352 355 0.99:1
AnimationMinimalPerf.default 399 408 0.98:1
DatepickerMinimalPerf.default 5629 5766 0.98:1
DropdownManyItemsPerf.default 701 713 0.98:1
ProviderMergeThemesPerf.default 1754 1796 0.98:1
AlertMinimalPerf.default 270 279 0.97:1
BoxMinimalPerf.default 347 358 0.97:1
ButtonSlotsPerf.default 551 569 0.97:1
CarouselMinimalPerf.default 483 496 0.97:1
DividerMinimalPerf.default 365 376 0.97:1
ItemLayoutMinimalPerf.default 1226 1265 0.97:1
RosterPerf.default 1221 1258 0.97:1
ProviderMinimalPerf.default 1169 1200 0.97:1
SkeletonMinimalPerf.default 347 359 0.97:1
IconMinimalPerf.default 609 635 0.96:1
TreeMinimalPerf.default 790 828 0.95:1
AccordionMinimalPerf.default 160 185 0.86:1

@andrefcdias andrefcdias removed their assignment Oct 4, 2021
@bsunderhus bsunderhus merged commit 4d16a2f into microsoft:master Oct 4, 2021
@bsunderhus bsunderhus deleted the react-card-forwardrefcomponent branch October 4, 2021 20:10
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
)

* Adds ForwardRefComponent to react-card components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants