Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-slider: Adjust signature to use ForwardRefComponent #20091

Merged

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

Description of changes

Adds ForwardRefComponent on component declaration as followed by #19923

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-slider
RangedSlider
35.092 kB
10.615 kB
react-slider
Slider
32.072 kB
10.166 kB
🤖 This report was generated against a3391fbf4643431624961121002c512b130a1126

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1025 1016 5000
BaseButton mount 999 976 5000
Breadcrumb mount 2882 2784 1000
ButtonNext mount 553 565 5000
Checkbox mount 1622 1618 5000
CheckboxBase mount 1471 1393 5000
ChoiceGroup mount 5129 5065 5000
ComboBox mount 1058 1020 1000
CommandBar mount 10997 11193 1000
ContextualMenu mount 6967 6817 1000
DefaultButton mount 1228 1202 5000
DetailsRow mount 4111 4132 5000
DetailsRowFast mount 4220 4102 5000
DetailsRowNoStyles mount 3869 3827 5000
Dialog mount 2623 2632 1000
DocumentCardTitle mount 192 168 1000
Dropdown mount 3467 3501 5000
FluentProviderNext mount 3667 3725 5000
FluentProviderWithTheme mount 237 223 10
FluentProviderWithTheme virtual-rerender 116 109 10
FluentProviderWithTheme virtual-rerender-with-unmount 254 262 10
FocusTrapZone mount 1945 2028 5000
FocusZone mount 2016 1975 5000
IconButton mount 1916 1867 5000
Label mount 371 368 5000
Layer mount 3264 3225 5000
Link mount 513 506 5000
MakeStyles mount 1987 1960 50000
MenuButton mount 1593 1567 5000
MessageBar mount 2193 2160 5000
Nav mount 3651 3586 1000
OverflowSet mount 1203 1162 5000
Panel mount 2570 2566 1000
Persona mount 875 899 1000
Pivot mount 1515 1548 1000
PrimaryButton mount 1403 1477 5000
Rating mount 8369 8268 5000
SearchBox mount 1447 1444 5000
Shimmer mount 2740 2852 5000
Slider mount 2127 2143 5000
SpinButton mount 5426 5385 5000
Spinner mount 463 487 5000
SplitButton mount 3356 3444 5000
Stack mount 555 541 5000
StackWithIntrinsicChildren mount 1882 1843 5000
StackWithTextChildren mount 5154 5080 5000
SwatchColorPicker mount 11370 11119 5000
Tabs mount 1531 1560 1000
TagPicker mount 2870 2890 5000
TeachingBubble mount 14099 14001 5000
Text mount 492 501 5000
TextField mount 1497 1455 5000
ThemeProvider mount 1294 1251 5000
ThemeProvider virtual-rerender 659 657 5000
ThemeProvider virtual-rerender-with-unmount 2004 2028 5000
Toggle mount 906 891 5000
buttonNative mount 151 160 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LabelMinimalPerf.default 449 392 1.15:1
ButtonMinimalPerf.default 194 174 1.11:1
ChatWithPopoverPerf.default 427 386 1.11:1
RadioGroupMinimalPerf.default 502 457 1.1:1
TableMinimalPerf.default 457 414 1.1:1
ListNestedPerf.default 613 567 1.08:1
ChatDuplicateMessagesPerf.default 339 320 1.06:1
RefMinimalPerf.default 264 250 1.06:1
SegmentMinimalPerf.default 389 368 1.06:1
SliderMinimalPerf.default 1885 1781 1.06:1
AlertMinimalPerf.default 297 284 1.05:1
AvatarMinimalPerf.default 222 212 1.05:1
ButtonSlotsPerf.default 606 575 1.05:1
AnimationMinimalPerf.default 429 415 1.03:1
CardMinimalPerf.default 600 583 1.03:1
DatepickerMinimalPerf.default 5930 5739 1.03:1
DividerMinimalPerf.default 386 373 1.03:1
FlexMinimalPerf.default 293 285 1.03:1
ReactionMinimalPerf.default 400 389 1.03:1
TreeWith60ListItems.default 194 189 1.03:1
AttachmentSlotsPerf.default 1185 1166 1.02:1
ItemLayoutMinimalPerf.default 1309 1279 1.02:1
LayoutMinimalPerf.default 382 375 1.02:1
MenuButtonMinimalPerf.default 1784 1755 1.02:1
SkeletonMinimalPerf.default 371 363 1.02:1
BoxMinimalPerf.default 380 377 1.01:1
DropdownManyItemsPerf.default 742 733 1.01:1
GridMinimalPerf.default 354 352 1.01:1
HeaderSlotsPerf.default 827 822 1.01:1
ImageMinimalPerf.default 396 394 1.01:1
ListCommonPerf.default 667 659 1.01:1
ProviderMergeThemesPerf.default 1848 1837 1.01:1
ToolbarMinimalPerf.default 1003 989 1.01:1
CheckboxMinimalPerf.default 2933 2930 1:1
DialogMinimalPerf.default 814 810 1:1
DropdownMinimalPerf.default 3413 3400 1:1
MenuMinimalPerf.default 905 904 1:1
SplitButtonMinimalPerf.default 4548 4537 1:1
TooltipMinimalPerf.default 1108 1112 1:1
TreeMinimalPerf.default 849 852 1:1
VideoMinimalPerf.default 678 680 1:1
AccordionMinimalPerf.default 170 171 0.99:1
CarouselMinimalPerf.default 511 514 0.99:1
FormMinimalPerf.default 428 434 0.99:1
HeaderMinimalPerf.default 387 391 0.99:1
LoaderMinimalPerf.default 752 761 0.99:1
ProviderMinimalPerf.default 1156 1167 0.99:1
TableManyItemsPerf.default 2045 2073 0.99:1
ChatMinimalPerf.default 663 678 0.98:1
InputMinimalPerf.default 1383 1407 0.98:1
ListWith60ListItems.default 683 699 0.98:1
CustomToolbarPrototype.default 4409 4479 0.98:1
ButtonOverridesMissPerf.default 1873 1938 0.97:1
EmbedMinimalPerf.default 4470 4609 0.97:1
PopupMinimalPerf.default 632 649 0.97:1
StatusMinimalPerf.default 685 709 0.97:1
IconMinimalPerf.default 655 676 0.97:1
TextAreaMinimalPerf.default 535 552 0.97:1
AttachmentMinimalPerf.default 165 171 0.96:1
RosterPerf.default 1210 1265 0.96:1
TextMinimalPerf.default 360 375 0.96:1
ListMinimalPerf.default 533 576 0.93:1
PortalMinimalPerf.default 195 209 0.93:1

@bsunderhus bsunderhus merged commit f4f0628 into microsoft:master Oct 4, 2021
@bsunderhus bsunderhus deleted the react-slider-forwardrefcomponent branch October 4, 2021 20:10
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…20091)

* Adds ForwardRefComponent to react-slider components declaration

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants