-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-switch: Adjust signature to use ForwardRefComponent #20093
Merged
bsunderhus
merged 2 commits into
microsoft:master
from
bsunderhus:react-switch-forwardrefcomponent
Oct 4, 2021
Merged
react-switch: Adjust signature to use ForwardRefComponent #20093
bsunderhus
merged 2 commits into
microsoft:master
from
bsunderhus:react-switch-forwardrefcomponent
Oct 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
requested review from
behowell,
czearing,
ecraig12345,
khmakoto and
a team
as code owners
October 4, 2021 11:34
18 tasks
📊 Bundle size reportUnchanged fixtures
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eeb7d5e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a3391fbf4643431624961121002c512b130a1126 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 990 | 999 | 5000 | |
BaseButton | mount | 982 | 991 | 5000 | |
Breadcrumb | mount | 2651 | 2672 | 1000 | |
ButtonNext | mount | 525 | 551 | 5000 | |
Checkbox | mount | 1665 | 1713 | 5000 | |
CheckboxBase | mount | 1442 | 1463 | 5000 | |
ChoiceGroup | mount | 5379 | 5133 | 5000 | |
ComboBox | mount | 1075 | 1069 | 1000 | |
CommandBar | mount | 10499 | 10733 | 1000 | |
ContextualMenu | mount | 6626 | 6596 | 1000 | |
DefaultButton | mount | 1210 | 1204 | 5000 | |
DetailsRow | mount | 4002 | 4010 | 5000 | |
DetailsRowFast | mount | 4003 | 4035 | 5000 | |
DetailsRowNoStyles | mount | 3852 | 3805 | 5000 | |
Dialog | mount | 2568 | 2549 | 1000 | |
DocumentCardTitle | mount | 186 | 174 | 1000 | |
Dropdown | mount | 3342 | 3369 | 5000 | |
FluentProviderNext | mount | 3244 | 3258 | 5000 | |
FluentProviderWithTheme | mount | 207 | 221 | 10 | |
FluentProviderWithTheme | virtual-rerender | 109 | 112 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 239 | 248 | 10 | |
FocusTrapZone | mount | 1880 | 1881 | 5000 | |
FocusZone | mount | 1793 | 1908 | 5000 | |
IconButton | mount | 1878 | 1916 | 5000 | |
Label | mount | 361 | 370 | 5000 | |
Layer | mount | 3168 | 3124 | 5000 | |
Link | mount | 542 | 535 | 5000 | |
MakeStyles | mount | 1810 | 1855 | 50000 | |
MenuButton | mount | 1606 | 1559 | 5000 | |
MessageBar | mount | 2083 | 2068 | 5000 | |
Nav | mount | 3598 | 3542 | 1000 | |
OverflowSet | mount | 1204 | 1213 | 5000 | |
Panel | mount | 2403 | 2498 | 1000 | |
Persona | mount | 898 | 907 | 1000 | |
Pivot | mount | 1555 | 1487 | 1000 | |
PrimaryButton | mount | 1379 | 1395 | 5000 | |
Rating | mount | 8491 | 8445 | 5000 | |
SearchBox | mount | 1464 | 1446 | 5000 | |
Shimmer | mount | 2771 | 2791 | 5000 | |
Slider | mount | 2063 | 2087 | 5000 | |
SpinButton | mount | 5429 | 5326 | 5000 | |
Spinner | mount | 465 | 449 | 5000 | |
SplitButton | mount | 3391 | 3358 | 5000 | |
Stack | mount | 559 | 536 | 5000 | |
StackWithIntrinsicChildren | mount | 1950 | 1899 | 5000 | |
StackWithTextChildren | mount | 5235 | 5217 | 5000 | |
SwatchColorPicker | mount | 11200 | 11027 | 5000 | |
Tabs | mount | 1545 | 1500 | 1000 | |
TagPicker | mount | 2782 | 2838 | 5000 | |
TeachingBubble | mount | 13367 | 13297 | 5000 | |
Text | mount | 476 | 508 | 5000 | |
TextField | mount | 1596 | 1575 | 5000 | |
ThemeProvider | mount | 1278 | 1252 | 5000 | |
ThemeProvider | virtual-rerender | 647 | 643 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2046 | 1996 | 5000 | |
Toggle | mount | 886 | 882 | 5000 | |
buttonNative | mount | 135 | 124 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 220 | 188 | 1.17:1 |
TreeWith60ListItems.default | 205 | 178 | 1.15:1 |
SkeletonMinimalPerf.default | 414 | 376 | 1.1:1 |
ReactionMinimalPerf.default | 434 | 407 | 1.07:1 |
AttachmentMinimalPerf.default | 190 | 179 | 1.06:1 |
ItemLayoutMinimalPerf.default | 1356 | 1282 | 1.06:1 |
SegmentMinimalPerf.default | 407 | 383 | 1.06:1 |
TableMinimalPerf.default | 452 | 427 | 1.06:1 |
AccordionMinimalPerf.default | 179 | 171 | 1.05:1 |
CarouselMinimalPerf.default | 509 | 487 | 1.05:1 |
GridMinimalPerf.default | 384 | 366 | 1.05:1 |
HeaderSlotsPerf.default | 872 | 829 | 1.05:1 |
LabelMinimalPerf.default | 449 | 429 | 1.05:1 |
LayoutMinimalPerf.default | 423 | 401 | 1.05:1 |
ListCommonPerf.default | 705 | 674 | 1.05:1 |
ProviderMinimalPerf.default | 1241 | 1184 | 1.05:1 |
StatusMinimalPerf.default | 751 | 713 | 1.05:1 |
MenuMinimalPerf.default | 963 | 928 | 1.04:1 |
RadioGroupMinimalPerf.default | 497 | 478 | 1.04:1 |
AlertMinimalPerf.default | 317 | 307 | 1.03:1 |
AvatarMinimalPerf.default | 225 | 218 | 1.03:1 |
BoxMinimalPerf.default | 391 | 381 | 1.03:1 |
ChatWithPopoverPerf.default | 426 | 414 | 1.03:1 |
DropdownMinimalPerf.default | 3324 | 3239 | 1.03:1 |
FlexMinimalPerf.default | 311 | 302 | 1.03:1 |
ListWith60ListItems.default | 724 | 706 | 1.03:1 |
IconMinimalPerf.default | 677 | 655 | 1.03:1 |
ButtonOverridesMissPerf.default | 1908 | 1871 | 1.02:1 |
ButtonSlotsPerf.default | 610 | 598 | 1.02:1 |
DropdownManyItemsPerf.default | 761 | 748 | 1.02:1 |
SplitButtonMinimalPerf.default | 4633 | 4549 | 1.02:1 |
TextMinimalPerf.default | 377 | 369 | 1.02:1 |
TooltipMinimalPerf.default | 1127 | 1103 | 1.02:1 |
ChatDuplicateMessagesPerf.default | 322 | 319 | 1.01:1 |
ChatMinimalPerf.default | 734 | 724 | 1.01:1 |
DatepickerMinimalPerf.default | 5971 | 5900 | 1.01:1 |
DialogMinimalPerf.default | 830 | 820 | 1.01:1 |
DividerMinimalPerf.default | 409 | 404 | 1.01:1 |
HeaderMinimalPerf.default | 408 | 404 | 1.01:1 |
ImageMinimalPerf.default | 432 | 429 | 1.01:1 |
ListMinimalPerf.default | 554 | 546 | 1.01:1 |
ListNestedPerf.default | 609 | 602 | 1.01:1 |
MenuButtonMinimalPerf.default | 1796 | 1783 | 1.01:1 |
PopupMinimalPerf.default | 617 | 612 | 1.01:1 |
TableManyItemsPerf.default | 2109 | 2088 | 1.01:1 |
CustomToolbarPrototype.default | 4379 | 4324 | 1.01:1 |
ToolbarMinimalPerf.default | 1029 | 1021 | 1.01:1 |
CardMinimalPerf.default | 606 | 608 | 1:1 |
CheckboxMinimalPerf.default | 2878 | 2881 | 1:1 |
RosterPerf.default | 1299 | 1301 | 1:1 |
RefMinimalPerf.default | 245 | 244 | 1:1 |
TreeMinimalPerf.default | 879 | 883 | 1:1 |
AnimationMinimalPerf.default | 439 | 444 | 0.99:1 |
AttachmentSlotsPerf.default | 1158 | 1164 | 0.99:1 |
EmbedMinimalPerf.default | 4474 | 4499 | 0.99:1 |
InputMinimalPerf.default | 1372 | 1386 | 0.99:1 |
TextAreaMinimalPerf.default | 583 | 587 | 0.99:1 |
LoaderMinimalPerf.default | 757 | 771 | 0.98:1 |
PortalMinimalPerf.default | 177 | 181 | 0.98:1 |
ProviderMergeThemesPerf.default | 1738 | 1768 | 0.98:1 |
VideoMinimalPerf.default | 700 | 716 | 0.98:1 |
FormMinimalPerf.default | 463 | 478 | 0.97:1 |
SliderMinimalPerf.default | 1766 | 1813 | 0.97:1 |
andrefcdias
approved these changes
Oct 4, 2021
khmakoto
approved these changes
Oct 4, 2021
czearing
approved these changes
Oct 4, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…20093) * Adds ForwardRefComponent to react-switch components declaration * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn change
Description of changes
Adds
ForwardRefComponent
on component declaration as followed by #19923