fix: remove row focus background color #29364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the the row focus background so that focus outline in the teams high contrast theme appears clearly Fixes microsoft#29033
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 64 | 58 | 10 | Possible regression |
| InfoButton | mount | 14 | 11 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 620 | 625 | 5000 | |
| Button | mount | 318 | 320 | 5000 | |
| Field | mount | 1132 | 1101 | 5000 | |
| FluentProvider | mount | 685 | 669 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 64 | 58 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 75 | 10 | |
| InfoButton | mount | 14 | 11 | 5000 | Possible regression |
| MakeStyles | mount | 825 | 835 | 50000 | |
| Persona | mount | 1711 | 1676 | 5000 | |
| SpinButton | mount | 1299 | 1323 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 42c02cc:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b1c71b351bc23d512f9dca839bdc43f3ab32c707 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
reviewed
Oct 3, 2023
packages/react-components/react-table/src/components/TableRow/useTableRowStyles.styles.ts
Outdated
Show resolved
Hide resolved
ling1726
force-pushed
the
react-table/fix/hc-focus-indicator
branch
from
0cd91f3
to
ad1e5a6
Compare
layershifter
approved these changes
Oct 9, 2023
miroslavstastny
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the the row focus background so that focus state in the teams high contrast theme appears clearly
Before
Light
Dark
Teams HC
After
Light
Dark
Teams HC
Fixes #29033