Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: Initial skeleton and spec #31184

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Carousel: Initial skeleton and spec #31184

merged 6 commits into from
Apr 25, 2024

Conversation

Mitch-At-Work
Copy link
Contributor

Initial spec.md and skeleton definition of: #26647

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 24, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 82 83 0.99:1 analysis
AccordionMinimalPerf.default 79 95 0.83:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 92 80 1.15:1
ListNestedPerf.default 342 311 1.1:1
RefMinimalPerf.default 118 109 1.08:1
IconMinimalPerf.default 405 377 1.07:1
CheckboxMinimalPerf.default 1185 1114 1.06:1
FlexMinimalPerf.default 164 154 1.06:1
GridMinimalPerf.default 199 187 1.06:1
LayoutMinimalPerf.default 206 195 1.06:1
SkeletonMinimalPerf.default 207 195 1.06:1
TreeWith60ListItems.default 89 84 1.06:1
AnimationMinimalPerf.default 308 293 1.05:1
CarouselMinimalPerf.default 269 256 1.05:1
DividerMinimalPerf.default 215 204 1.05:1
HeaderMinimalPerf.default 211 201 1.05:1
TextMinimalPerf.default 197 188 1.05:1
ButtonSlotsPerf.default 328 315 1.04:1
ChatMinimalPerf.default 454 437 1.04:1
HeaderSlotsPerf.default 482 462 1.04:1
ImageMinimalPerf.default 231 223 1.04:1
ListCommonPerf.default 405 391 1.04:1
SegmentMinimalPerf.default 200 192 1.04:1
LabelMinimalPerf.default 228 222 1.03:1
ProviderMergeThemesPerf.default 662 643 1.03:1
ProviderMinimalPerf.default 207 201 1.03:1
RadioGroupMinimalPerf.default 267 259 1.03:1
StatusMinimalPerf.default 399 388 1.03:1
TextAreaMinimalPerf.default 285 276 1.03:1
CustomToolbarPrototype.default 1479 1442 1.03:1
TreeMinimalPerf.default 492 479 1.03:1
AttachmentSlotsPerf.default 656 644 1.02:1
CardMinimalPerf.default 317 312 1.02:1
DialogMinimalPerf.default 447 437 1.02:1
DropdownManyItemsPerf.default 393 387 1.02:1
InputMinimalPerf.default 543 533 1.02:1
ListMinimalPerf.default 323 318 1.02:1
SplitButtonMinimalPerf.default 2309 2265 1.02:1
ButtonOverridesMissPerf.default 653 649 1.01:1
ChatDuplicateMessagesPerf.default 153 152 1.01:1
DropdownMinimalPerf.default 1448 1428 1.01:1
ItemLayoutMinimalPerf.default 709 699 1.01:1
PopupMinimalPerf.default 348 345 1.01:1
ToolbarMinimalPerf.default 539 534 1.01:1
DatepickerMinimalPerf.default 3507 3502 1:1
EmbedMinimalPerf.default 1891 1892 1:1
MenuButtonMinimalPerf.default 953 952 1:1
SliderMinimalPerf.default 739 741 1:1
VideoMinimalPerf.default 467 469 1:1
AvatarMinimalPerf.default 107 108 0.99:1
ListWith60ListItems.default 380 383 0.99:1
MenuMinimalPerf.default 500 504 0.99:1
AlertMinimalPerf.default 162 165 0.98:1
RosterPerf.default 1540 1576 0.98:1
TooltipMinimalPerf.default 1300 1329 0.98:1
BoxMinimalPerf.default 201 208 0.97:1
LoaderMinimalPerf.default 191 197 0.97:1
ReactionMinimalPerf.default 210 217 0.97:1
TableManyItemsPerf.default 1096 1126 0.97:1
TableMinimalPerf.default 244 254 0.96:1
AttachmentMinimalPerf.default 82 86 0.95:1
FormMinimalPerf.default 224 235 0.95:1
ChatWithPopoverPerf.default 183 196 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 34 36 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 633 615 5000
Button mount 301 303 5000
Field mount 1124 1100 5000
FluentProvider mount 704 703 5000
FluentProviderWithTheme mount 81 86 10
FluentProviderWithTheme virtual-rerender 34 36 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 70 84 10
MakeStyles mount 873 875 50000
Persona mount 1762 1719 5000
SpinButton mount 1450 1436 5000
SwatchPicker mount 1538 1511 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 644 628 5000
Breadcrumb mount 1687 1708 1000
Checkbox mount 1685 1730 5000
CheckboxBase mount 1508 1513 5000
ChoiceGroup mount 3064 2958 5000
ComboBox mount 692 671 1000
CommandBar mount 6734 6649 1000
ContextualMenu mount 14779 14677 1000
DefaultButton mount 808 818 5000
DetailsRow mount 2234 2233 5000
DetailsRowFast mount 2265 2220 5000
DetailsRowNoStyles mount 2029 2059 5000
Dialog mount 2649 2839 1000
DocumentCardTitle mount 228 230 1000
Dropdown mount 2044 2008 5000
FocusTrapZone mount 1155 1180 5000
FocusZone mount 1101 1100 5000
GroupedList mount 42253 42815 2
GroupedList virtual-rerender 20291 20271 2
GroupedList virtual-rerender-with-unmount 55903 54784 2
GroupedListV2 mount 230 226 2
GroupedListV2 virtual-rerender 210 206 2
GroupedListV2 virtual-rerender-with-unmount 238 228 2
IconButton mount 1172 1168 5000
Label mount 357 372 5000
Layer mount 2772 2810 5000
Link mount 387 393 5000
MenuButton mount 1006 988 5000
MessageBar mount 21840 21708 5000
Nav mount 2041 2062 1000
OverflowSet mount 818 806 5000
Panel mount 1880 1841 1000
Persona mount 744 796 1000
Pivot mount 903 917 1000
PrimaryButton mount 961 933 5000
Rating mount 4793 4746 5000
SearchBox mount 934 913 5000
Shimmer mount 1941 1905 5000
Slider mount 1350 1336 5000
SpinButton mount 3030 3015 5000
Spinner mount 407 391 5000
SplitButton mount 1899 1897 5000
Stack mount 411 416 5000
StackWithIntrinsicChildren mount 873 867 5000
StackWithTextChildren mount 2713 2672 5000
SwatchColorPicker mount 6406 6534 5000
TagPicker mount 1497 1487 5000
Text mount 367 371 5000
TextField mount 991 944 5000
ThemeProvider mount 848 823 5000
ThemeProvider virtual-rerender 587 584 5000
ThemeProvider virtual-rerender-with-unmount 1291 1277 5000
Toggle mount 612 616 5000
buttonNative mount 188 206 5000

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review April 24, 2024 19:56
ling1726
ling1726 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the assumption that this is all autogenerated code

@Mitch-At-Work Mitch-At-Work merged commit 293b0b9 into microsoft:master Apr 25, 2024
21 checks passed
stevencomsft pushed a commit to stevencomsft/fluentui that referenced this pull request Apr 25, 2024
@Mitch-At-Work @stevencomsft
Carousel: Initial skeleton and spec (microsoft#31184)
1c2fdbb
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Mitch-At-Work @miroslavstastny
Carousel: Initial skeleton and spec (microsoft#31184)
4e43bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spmonahan spmonahan spmonahan approved these changes

@ling1726 ling1726 ling1726 approved these changes

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mitch-At-Work @fabricteam @ling1726 @spmonahan