Carousel UI: Buttons, Images & Looping #31466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ling1726
reviewed
May 28, 2024
packages/react-components/react-carousel-preview/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 28, 2024
packages/react-components/react-carousel-preview/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 28, 2024
...react-carousel-preview/src/components/CarouselNavImageButton/CarouselNavImageButton.types.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-carousel-preview/src/components/CarouselButton/useCarouselButton.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel-preview/src/components/CarouselContext.types.ts
Outdated
Show resolved
Hide resolved
...-components/react-carousel-preview/src/components/CarouselNav/useCarouselNavStyles.styles.ts
Outdated
Show resolved
Hide resolved
...react-carousel-preview/src/components/CarouselNavImageButton/CarouselNavImageButton.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel-preview/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel-preview/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel-preview/src/components/useCarouselWalker.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
May 29, 2024
ling1726
reviewed
May 29, 2024
packages/react-components/react-carousel-preview/src/components/Carousel/Carousel.types.ts
Outdated
Show resolved
Hide resolved
...nents/react-carousel-preview/src/components/CarouselButton/useCarouselButtonStyles.styles.ts
Show resolved
Hide resolved
brandonthomas
approved these changes
May 30, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No loop available
Buttons were simple react-buttons only
No ImageNavButton available.
New Behavior
Looping optionally added to carousel navigation
Image buttons with correct chevrons and coloring/background.
New NavImageButtons for card preview scenarios.
Related Issue(s)
#26647