refactor(motion): refactor Collapse and variant functions #32833
+399
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpenner
force-pushed
the
feat/collapse-refactor
branch
from
5094245
to
666992b
Compare
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 643 | 623 | 5000 | |
| Button | mount | 323 | 325 | 5000 | |
| Field | mount | 1185 | 1180 | 5000 | |
| FluentProvider | mount | 717 | 723 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 83 | 10 | |
| MakeStyles | mount | 908 | 877 | 50000 | |
| Persona | mount | 1781 | 1798 | 5000 | |
| SpinButton | mount | 1444 | 1425 | 5000 | |
| SwatchPicker | mount | 1720 | 1659 | 5000 |
fabricteam
reviewed
Sep 13, 2024
| enter: { duration, easing, keyframes: enterKeyframes }, | ||
| exit: { duration, easing, keyframes: exitKeyframes }, | ||
| }; | ||
| import { motionTokens, type PresenceMotionFnCreator, createPresenceComponent } from '@fluentui/react-motion'; |
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 17 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay RTL.chromium.png | 1141 | Changed |
| Drawer.Full Overlay High Contrast.chromium.png | 3769 | Changed |
robertpenner
force-pushed
the
feat/collapse-refactor
branch
2 times, most recently
from
d310af2
to
04630c8
Compare
robertpenner
force-pushed
the
feat/collapse-refactor
branch
from
04630c8
to
a946a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)