-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: table selection checkbox or radio should be rendered even if invisible #32846
Open
smhigley
wants to merge
3
commits into
microsoft:master
Choose a base branch
from
smhigley:table-invisible-selection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 35 | 36 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 650 | 616 | 5000 | |
Button | mount | 295 | 295 | 5000 | |
Field | mount | 1107 | 1142 | 5000 | |
FluentProvider | mount | 704 | 713 | 5000 | |
FluentProviderWithTheme | mount | 85 | 77 | 10 | |
FluentProviderWithTheme | virtual-rerender | 35 | 36 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 82 | 10 | |
MakeStyles | mount | 861 | 875 | 50000 | |
Persona | mount | 1765 | 1744 | 5000 | |
SpinButton | mount | 1403 | 1414 | 5000 | |
SwatchPicker | mount | 1679 | 1661 | 5000 |
fabricteam
reviewed
Sep 16, 2024
mainframev
reviewed
Sep 17, 2024
packages/react-components/react-slider/stories/src/Slider/SliderControlled.stories.tsx
Outdated
Show resolved
Hide resolved
mainframev
approved these changes
Sep 17, 2024
layershifter
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
If authors set
selectionCell: {{ invisible: true }}
without passing any data to theradioIndicator
orcheckboxIndicator
slots, the radio/checkbox input would not be rendered in the DOM. For some (e.g. touch) screen reader and voice control users, this means that they would not be able to select rows.Our examples do pass in data (an
aria-label
) to the indicator slot, so the issue does not show up in our docs site. While authors should always pass in an accessible name to the indicator slot they're using, it's still better to have an unnamed radio or checkbox than to have none at all.New Behavior
The
radioIndicator
andcheckboxIndicator
slots render by default even withinvisible: true
. The visuals don't change (invisible
will cause theopacity: 0
style to be added), just the DOM.This also means that the lack of an accessible name for the radio/checkbox inputs should be able to be caught in automated tests.
Related Issue(s)
Not a github issue, but this came up in a Teams question from a partner team who got an a11y issue about the selection cells being empty.