fix: [fluent-text] removes display inheritance so all html elements can render #32874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
marchbox
approved these changes
Sep 20, 2024
davatron5000
approved these changes
Sep 20, 2024
mlijanto
approved these changes
Sep 26, 2024
mltejera
pushed a commit
to mltejera/office-ui-fabric-react
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
the catch all slotted selector was setting
display: inherit, if the host hasdisplay: contentsset it causes some html elements (SVG) to not render.https://drafts.csswg.org/css-display/#unbox-svg
New Behavior
Removes the inheritance of the
displayRelated Issue(s)