Remove border property containing typo from .ms-PositioningContainer-layerHost root #32885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Sep 21, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 623 | 5000 | |
| Breadcrumb | mount | 1706 | 1718 | 1000 | |
| Checkbox | mount | 1712 | 1703 | 5000 | |
| CheckboxBase | mount | 1506 | 1473 | 5000 | |
| ChoiceGroup | mount | 2952 | 2934 | 5000 | |
| ComboBox | mount | 686 | 684 | 1000 | |
| CommandBar | mount | 6646 | 6570 | 1000 | |
| ContextualMenu | mount | 12106 | 12293 | 1000 | |
| DefaultButton | mount | 794 | 813 | 5000 | |
| DetailsRow | mount | 2212 | 2195 | 5000 | |
| DetailsRowFast | mount | 2250 | 2271 | 5000 | |
| DetailsRowNoStyles | mount | 2071 | 2003 | 5000 | |
| Dialog | mount | 2809 | 2861 | 1000 | |
| DocumentCardTitle | mount | 246 | 226 | 1000 | |
| Dropdown | mount | 1982 | 1999 | 5000 | |
| FocusTrapZone | mount | 1162 | 1174 | 5000 | |
| FocusZone | mount | 1109 | 1090 | 5000 | |
| GroupedList | mount | 42824 | 42864 | 2 | |
| GroupedList | virtual-rerender | 20322 | 20671 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51821 | 52017 | 2 | |
| GroupedListV2 | mount | 235 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 225 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 231 | 2 | |
| IconButton | mount | 1136 | 1132 | 5000 | |
| Label | mount | 347 | 340 | 5000 | |
| Layer | mount | 2740 | 2744 | 5000 | |
| Link | mount | 386 | 395 | 5000 | |
| MenuButton | mount | 986 | 992 | 5000 | |
| MessageBar | mount | 21229 | 21279 | 5000 | |
| Nav | mount | 2055 | 2026 | 1000 | |
| OverflowSet | mount | 783 | 813 | 5000 | |
| Panel | mount | 1870 | 1877 | 1000 | |
| Persona | mount | 739 | 751 | 1000 | |
| Pivot | mount | 917 | 917 | 1000 | |
| PrimaryButton | mount | 936 | 923 | 5000 | |
| Rating | mount | 4706 | 4661 | 5000 | |
| SearchBox | mount | 920 | 921 | 5000 | |
| Shimmer | mount | 1885 | 1887 | 5000 | |
| Slider | mount | 1348 | 1352 | 5000 | |
| SpinButton | mount | 3007 | 2990 | 5000 | |
| Spinner | mount | 390 | 401 | 5000 | |
| SplitButton | mount | 1912 | 1870 | 5000 | |
| Stack | mount | 421 | 416 | 5000 | |
| StackWithIntrinsicChildren | mount | 869 | 890 | 5000 | |
| StackWithTextChildren | mount | 2745 | 2809 | 5000 | |
| SwatchColorPicker | mount | 6400 | 6409 | 5000 | |
| TagPicker | mount | 1458 | 1509 | 5000 | |
| Text | mount | 394 | 386 | 5000 | |
| TextField | mount | 951 | 949 | 5000 | |
| ThemeProvider | mount | 853 | 858 | 5000 | |
| ThemeProvider | virtual-rerender | 589 | 592 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1301 | 1301 | 5000 | |
| Toggle | mount | 620 | 616 | 5000 | |
| buttonNative | mount | 195 | 192 | 5000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
There is a typo in the
.ms-PositioningContainer-layerHostroot style value for 'border' that Chrome drops, so removing the style completely from source. It has been there since https://github.com/microsoft/fluentui/blame/4cb8f290e4b35a8566f4d568c6aa2b556d9d726d/packages/office-ui-fabric-react/src/components/Coachmark/PositioningContainer/PositioningContainer.styles.ts#L50.New Behavior
Property is removed and continues to not be present in browser.
cc: @FinnCowbell