-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workspace-plugin): prepare-initial-release - phase:stable - update additional files and properly resolve *-stories package.json definitions #32892
Merged
Hotell
merged 15 commits into
microsoft:master
from
Hotell:workspace/plugin/generators/fix-prepare-initial-release
Sep 24, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e additional files and properly resolve *-stories package.json definitions
Hotell
changed the title
fix(workspace-plugin): prepare-initial-release - phase:stable - updat…
fix(workspace-plugin): prepare-initial-release - phase:stable - update additional files and properly resolve *-stories package.json definitions
Sep 23, 2024
📊 Bundle size report✅ No changes found |
Hotell
commented
Sep 24, 2024
tools/workspace-plugin/src/generators/prepare-initial-release/lib/utils.ts
Show resolved
Hide resolved
Hotell
commented
Sep 24, 2024
tools/workspace-plugin/src/generators/prepare-initial-release/lib/utils.ts
Show resolved
Hide resolved
tudorpopams
approved these changes
Sep 24, 2024
Hotell
deleted the
workspace/plugin/generators/fix-prepare-initial-release
branch
September 24, 2024 10:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
prepare-initial-release
test suite to run cross platform as part of our tooling pipeline, to verify proper path resolution cross platform*-preview
occurences within all library sources ( egconsole.warn('@fluent/foo-preview: this is wrong')
-->console.warn('@fluent/foo: this is wrong')
Related Issue(s)