-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack: Promoting stack from experiments package to OUFR package. #7222
Conversation
@micahgodbolt I mentioned this in the email thread, but just to have it here, I updated the code so that the left/right/center notation is now start/end/center to adhere to LTR. |
…called Stack with a horizontal flag to determine orientation.
…c-react into stackPromotion
…f a single component called Stack.
…e Stack instead in experiments package.
…updating snapshot.
@khmakoto - I think it's a good time for you to write up a short description of high levels that you had to do to upgrade. I also think @micahgodbolt had a check list of stuff we really need to follow with promotions now that we've got the API nailed down. Here's an example #7254 |
We also have an issue for stack that it would be great to update/link to #5419 |
@khmakoto i've updated the original issue with or current 'new component' template. Can you move your comments, todos, code examples etc into that issue. Another thought is that we should focus on getting Stack correct in Experiments before moving it over to OUFR. i.e. smaller, more focused PRs to prep this control. Then one big PR to simply move it. |
Closing, please resolve and reopen when ready. |
Pull request checklist
$ npm run change
Description of changes
This PR has the purpose of promoting the Stack component from the
experiments
package to theoffice-ui-fabric-react
package.As part of this process, it was decided that we should change the approach we were using in the
experiments
package of having two separate components, HorizontalStack and VerticalStack, and instead have a single component Stack with a boolean propertyhorizontal
that determines if the stack is horizontal or vertical, with a vertical stack being the default.This change required modifying existing examples, tests and usage of Stack inside other components throughout the
experiments
package. The HorizontalStack and VerticalStack pages in theexperiments
website have also been removed and a Stack page has been added to theoffice-ui-fabric-react
website as part of this change.Focus areas to test
All the existing tests (snapshots, vr-tests, etc) for HorizontalStack and VerticalStack have been modified to use the singular Stack component and the new component has been tested against all of them to ensure conformance with how the previous components worked.
TO-DOs
wrap
functionality to vertical Stacks.Microsoft Reviewers: Open in CodeFlow