Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack: Promoting stack from experiments package to OUFR package. #7222

Closed
wants to merge 49 commits into from
Closed

Stack: Promoting stack from experiments package to OUFR package. #7222

wants to merge 49 commits into from

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Nov 27, 2018

Pull request checklist

Description of changes

This PR has the purpose of promoting the Stack component from the experiments package to the office-ui-fabric-react package.

As part of this process, it was decided that we should change the approach we were using in the experiments package of having two separate components, HorizontalStack and VerticalStack, and instead have a single component Stack with a boolean property horizontal that determines if the stack is horizontal or vertical, with a vertical stack being the default.

This change required modifying existing examples, tests and usage of Stack inside other components throughout the experiments package. The HorizontalStack and VerticalStack pages in the experiments website have also been removed and a Stack page has been added to the office-ui-fabric-react website as part of this change.

Focus areas to test

All the existing tests (snapshots, vr-tests, etc) for HorizontalStack and VerticalStack have been modified to use the singular Stack component and the new component has been tested against all of them to ensure conformance with how the previous components worked.

TO-DOs

  • Add the wrap functionality to vertical Stacks.
    • Add examples in documentation page.
    • Add snapshot tests.
    • Add vr-tests.
  • Finish documentation on Stack component.
    • Add overview.
    • Add Do's.
    • Add Dont's.
Microsoft Reviewers: Open in CodeFlow

…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Copy link
Member Author

@micahgodbolt I mentioned this in the email thread, but just to have it here, I updated the code so that the left/right/center notation is now start/end/center to adhere to LTR.

@khmakoto khmakoto self-assigned this Dec 5, 2018
@kenotron
Copy link
Member

kenotron commented Dec 5, 2018

@khmakoto - I think it's a good time for you to write up a short description of high levels that you had to do to upgrade. I also think @micahgodbolt had a check list of stuff we really need to follow with promotions now that we've got the API nailed down.

Here's an example #7254

@micahgodbolt
Copy link
Member

We also have an issue for stack that it would be great to update/link to #5419

@micahgodbolt
Copy link
Member

@khmakoto i've updated the original issue with or current 'new component' template. Can you move your comments, todos, code examples etc into that issue.

Another thought is that we should focus on getting Stack correct in Experiments before moving it over to OUFR. i.e. smaller, more focused PRs to prep this control. Then one big PR to simply move it.

@dzearing
Copy link
Member

Closing, please resolve and reopen when ready.

@dzearing dzearing closed this Dec 10, 2018
@khmakoto khmakoto deleted the stackPromotion branch January 3, 2019 19:25
@khmakoto khmakoto restored the stackPromotion branch January 3, 2019 19:25
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component: Stack
7 participants