-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack: Promoting component to OUFR package #8008
Conversation
…n components and examples that use it.
@@ -12926,6 +12953,14 @@ module ZIndexes { | |||
// WARNING: Unsupported export: DefaultProps | |||
// WARNING: Unsupported export: Spinner | |||
// WARNING: Unsupported export: SpinnerLabelPosition | |||
// WARNING: Unsupported export: StackItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natalieethell or @aditima What ever happened to the work being done on api-extractor
to support basic const
exports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supported in api-extractor 7
Hello @khmakoto! Because this pull request has the Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 |
packages/office-ui-fabric-react/src/components/Stack/Stack.styles.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config file changes look fine to me
you'll need to look at the bundlesize check in scripts/package.json |
Lots of fabulous approves! I'm merging this one! |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
Pull request checklist
$ npm run change
Description of changes
This PR promotes the
Stack
component from theexperiments
package into theoffice-ui-fabric-react
package. In doing so, the component has been added to theAppState
andAppDefinition
and all the components, examples and tests that were usingStack
have been updated to reference it fromoffice-ui-fabric-react
instead of fromexperiments
.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow