Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack: Promoting component to OUFR package #8008

Merged
merged 5 commits into from
Feb 15, 2019

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Feb 15, 2019

Pull request checklist

Description of changes

This PR promotes the Stack component from the experiments package into the office-ui-fabric-react package. In doing so, the component has been added to the AppState and AppDefinition and all the components, examples and tests that were using Stack have been updated to reference it from office-ui-fabric-react instead of from experiments.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@@ -12926,6 +12953,14 @@ module ZIndexes {
// WARNING: Unsupported export: DefaultProps
// WARNING: Unsupported export: Spinner
// WARNING: Unsupported export: SpinnerLabelPosition
// WARNING: Unsupported export: StackItem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalieethell or @aditima What ever happened to the work being done on api-extractor to support basic const exports?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supported in api-extractor 7

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

@size-auditor
Copy link

size-auditor bot commented Feb 15, 2019

Bundle test Size (minified) Diff from master
DocumentCard 275.689 kB ExceedsBaseline     9 bytes
ShimmeredDetailsList 269.803 kB ExceedsBaseline     9 bytes
Dropdown 265.874 kB ExceedsBaseline     9 bytes
Dialog 238.728 kB ExceedsBaseline     9 bytes
Pivot 231.242 kB ExceedsBaseline     9 bytes
DetailsList 254.913 kB ExceedsBaseline     9 bytes
Nav 232.256 kB ExceedsBaseline     9 bytes
CommandBar 243.854 kB ExceedsBaseline     9 bytes
ComboBox 282.423 kB ExceedsBaseline     9 bytes
SearchBox 228.856 kB ExceedsBaseline     9 bytes
MessageBar 232.133 kB ExceedsBaseline     9 bytes
SelectedItemsList 281.559 kB ExceedsBaseline     9 bytes
FloatingPicker 349.129 kB ExceedsBaseline     9 bytes
Facepile 259.175 kB ExceedsBaseline     9 bytes
SpinButton 236.257 kB ExceedsBaseline     9 bytes
KeytipLayer 208.435 kB ExceedsBaseline     9 bytes
Grid 225.941 kB ExceedsBaseline     9 bytes
Breadcrumb 243.613 kB ExceedsBaseline     9 bytes
SwatchColorPicker 241.343 kB ExceedsBaseline     3 bytes
ExtendedPicker 210.554 kB ExceedsBaseline     3 bytes
TeachingBubble 233.725 kB ExceedsBaseline     3 bytes
Panel 236.083 kB ExceedsBaseline     2 bytes
Keytip 192.778 kB ExceedsBaseline     2 bytes
Pickers 323.946 kB ExceedsBaseline     2 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config file changes look fine to me

@dzearing
Copy link
Member

you'll need to look at the bundlesize check in scripts/package.json

@kenotron
Copy link
Member

Lots of fabulous approves! I'm merging this one!

@kenotron kenotron merged commit 040ffd4 into microsoft:master Feb 15, 2019
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Feb 15, 2019
11 tasks
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto deleted the promoteStack branch February 15, 2019 18:03
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component: Stack
7 participants