forked from git-for-windows/git
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate git update-microsoft-git
with apt-get
#434
Merged
derrickstolee
merged 2 commits into
microsoft:vfs-2.33.0
from
derrickstolee:update-with-apt-get
Sep 29, 2021
Merged
Integrate git update-microsoft-git
with apt-get
#434
derrickstolee
merged 2 commits into
microsoft:vfs-2.33.0
from
derrickstolee:update-with-apt-get
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'git update-microsoft-git' builtin already interfaces with the git-for-windows/git upgrader on Windows and brew on macOS. Add an integration with apt-get on Ubuntu. The implementation attempts to call apt-get on all Linux machines, but it will report a failure when that is not available. The two commands are: 1. sudo apt-get update 2. sudo apt-get upgrade microsoft-git The first has an error message because that will likely only fail when apt-get does not exist on the path (or the user fails to supply the sudo password). The error condition for the second is passed to the user. It is possible that a user installs a package manually and not through a Microsoft feed, in which case the 'upgrade' command will fail with an error message. Extra newlines are added to provide whitespace between the Git messages and the dense output from apt-get. Signed-off-by: Derrick Stolee <[email protected]>
Update the Ubuntu/Linux install instructions to reference 'git update-microsoft-git'. Signed-off-by: Derrick Stolee <[email protected]>
ldennington
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran with the following scenarios locally on my 20.04 VM, and all behaved as expected:
microsoft-git
is not installed -> latest version ofmicrosoft-git
is installedmicrosoft-git
is installed but out-of-date ->microsoft-git
is upgraded to latest versionmicrosoft-git
is installed and up-to-date -> no-op
So I say 🚢 it!
dscho
pushed a commit
that referenced
this pull request
Oct 30, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Oct 30, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Oct 31, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Nov 4, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Nov 4, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Nov 10, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
derrickstolee
added a commit
that referenced
this pull request
Nov 15, 2021
…pt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 12, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 19, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…` with `apt-get` Extend the `git update-microsoft-git` builtin to call `apt-get` in a similar way we do `brew` on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
git update-microsoft-git
builtin to callapt-get
in a similar way we dobrew
on macOS.