fix: keyvault requires multi-tenant

[dciborow]

https://devblogs.microsoft.com/azure-sdk/guidance-for-multi-tenant-applications-using-the-azure-identity-libraries/

Description

Testing

Additional context

[github-actions]

Summary by GPT-4

This change adds the additionally_allowed_tenants parameter to the DefaultAzureCredential constructor with a value of "*" (a wildcard). This means that the credential will be allowed to authenticate with any tenant, not just the one specified in the environment variable or configuration file. This can be useful in scenarios where you want to allow access to multiple tenants without having to specify each one individually.

Suggestions

Here are some suggestions for improving the changes in this PR:

1. Add a comment explaining the reason for using additionally_allowed_tenants=["*"] in the DefaultAzureCredential() function call. This will help other developers understand the purpose of this change.

2. Consider breaking down the long lines of code into multiple lines for better readability. For example, you can assign the values of kv_client.get_secret("azure-open-ai").value and kv_client.get_secret("azure-openai-key").value to separate variables before assigning them to openai.api_base and openai.api_key.

Here's an example with these suggestions applied:

def _load_azure_openai_context() -> Context:
    if "OPENAI_API_KEY" in os.environ:
        openai.api_key = os.environ["OPENAI_API_KEY"]
    else:
        # Allow all tenants to access the key vault
        credential = DefaultAzureCredential(additionally_allowed_tenants=["*"])
        
        kv_client = SecretClient(
            vault_url=os.getenv("AZURE_KEY_VAULT_URL", C.AZURE_KEY_VAULT),
            credential=credential,
        )
        
        api_base_value = kv_client.get_secret("azure-open-ai").value  # type: ignore
        api_key_value = kv_client.get_secret("azure-openai-key").value  # type: ignore
        
        openai.api_base = os.environ["OPENAI_API_BASE"] = api_base_value
        openai.api_key = os.environ["OPENAI_API_KEY"] = api_key_value

    return Context()

This should make the code more readable and easier to understand for future developers working on this project.