Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip az login except for integration tests #62

Merged
merged 1 commit into from
May 8, 2023

Conversation

dciborow
Copy link
Collaborator

@dciborow dciborow commented May 8, 2023

Description

Testing

Additional context

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary by GPT-4

In this diff, the continue-on-error attribute is removed from the Azure/[email protected] action and replaced with an if condition. The action will now only run if the value of matrix.flags is equal to 'integration'. This means that the Azure login step will be skipped for any jobs in the matrix that do not have the 'integration' flag set.

Suggestions

Here are some suggestions for improving the changes in this PR:

  1. Add a comment explaining the purpose of the conditional statement:

    # Run Azure login only for integration tests
    if: ${{ matrix.flags == 'integration' }}
    
  2. Consider using a more descriptive name for the flags variable in the matrix, such as test_type or test_scope. This would make it clearer what the variable represents and improve readability.

  3. Ensure that all necessary dependencies and environment variables are properly set up for both integration and non-integration tests.

  4. Make sure to test these changes thoroughly to ensure that they do not introduce any unexpected behavior or break existing functionality.

@codecov-commenter
Copy link

Codecov Report

Merging #62 (78936d5) into main (3751927) will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   86.78%   85.28%   -1.50%     
==========================================
  Files          13       13              
  Lines         401      401              
  Branches       61       61              
==========================================
- Hits          348      342       -6     
- Misses         37       44       +7     
+ Partials       16       15       -1     
Flag Coverage Δ
integration ?
unittests 85.28% <ø> (ø)
unittests-3.10 85.28% <ø> (ø)
unittests-3.11 85.28% <ø> (ø)
unittests-3.8 85.28% <ø> (ø)
unittests-3.9 85.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@dciborow dciborow merged commit 136357a into main May 8, 2023
@dciborow dciborow deleted the dciborow/skip-az-login branch May 8, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants