Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dciborow/reduce test cases #68

Conversation

dciborow
Copy link
Collaborator

@dciborow dciborow commented May 9, 2023

Description

Testing

Additional context

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary by GPT-4

The changes in this commit remove some unused code and update the test functions to use the correct arguments. Specifically, it removes the MockStorageContext class and its usage, as well as the MockRepoReader class and its related functions. It also updates the test_cli_gpt_cli and test_cli_gpt_module functions to pass the correct argument to the cli_test function.

Suggestions

Here are some suggestions for improving the changes in this PR:

  1. Remove unused imports and classes:

In tests/conftest.py, you have removed the usage of SimpleDirectoryReader, MockStorageContext, MockRepoReader, and mock_load_data_from_branch. However, you have not removed their import statements and class definitions. To clean up the code, remove these unused imports and classes.

  1. Update test cases to reflect changes:

Since you have made changes to the code, it is important to update the test cases accordingly. Make sure that all test cases are still valid and cover the new changes made in this PR.

  1. Add comments explaining the changes:

It is always a good practice to add comments explaining why certain changes were made in a PR. This helps other developers understand the context behind those changes and makes it easier for them to review your code.

Overall, these suggestions should help improve the quality of your PR and make it easier for others to review your code.

@dciborow dciborow merged commit c37eeb0 into microsoft:dciborow/reduce-test-cases May 9, 2023
@dciborow dciborow deleted the dciborow/reduce-test-cases branch May 9, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant