Fixes numerous issues for benchmarking #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kernhanda
commented
Mar 2, 2023
kernhanda
commented
- Batch size was used in place of number of iterations per batch size when averaging batch size results.
- C++ benchmarking was developed on top of CallableFunc, which was designed for devices where multiple input sets were not needed. C++ benchmarking on the CPU, at least, needs these multiple input sets. This change fixes this issue.
- Number of iterations per batch was added as a command line argument
- CallableFunc instances for devices that need cache flushing will have extra data generated for them
* Batch size was used in place of number of iterations per batch size when averaging batch size results. * C++ benchmarking was developed on top of CallableFunc, which was designed for devices where multiple input sets were not needed. C++ benchmarking on the CPU, at least, needs these multiple input sets. This change fixes this issue.
masonremy
approved these changes
Mar 2, 2023
| batch_timings_ms: List[float] = [] | ||
| iterations = 1 | ||
| min_time_in_ms = min_time_in_sec * 1000 | ||
| while sum(batch_timings_ms) < min_time_in_ms or len(batch_timings_ms) >= batch_size: |
There was a problem hiding this comment.
Shouldn't this be "len(batch_timings_ms) < batch_size" instead?
There was a problem hiding this comment.
yes, you're right. good catch. fixed in #95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.