osversion: implement stringer interface, deprecate ToString() #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @tianon 😄 |
|
BTW, nothing but love for you JH! |
anmaxvl
approved these changes
Oct 18, 2022
|
So funny |
helsaawy
reviewed
Nov 28, 2022
osversion/osversion_windows_test.go
Outdated
|
|
||
| func TestOSVersionString(t *testing.T) { | ||
| v := OSVersion{ | ||
| Version: 123, |
There was a problem hiding this comment.
Technically, this should be 809042555 (123 | (2 << 8) | (12345 << 16)), but I think you can just set it to zero for this test
There was a problem hiding this comment.
Ah, good one; yes I can set it to 809042555 (I wanted to avoid setting it to 0, as that's the default value, and such values could e.g. be ignored / omit-empty-like things).
This allows the type to be used with fm.Sprintf() and similar uses. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
stringer_all_the_strings
branch
from
b5fefbb
to
d91924f
Compare
helsaawy
approved these changes
Nov 28, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the type to be used with fm.Sprintf() and similar uses.
To preview the GoDoc (pkg.go.dev);
GOOS=windows pkgsite -http=:6060 .