test: Add CRI benchmarks for container operations #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CRI API benchmarks to `cri-containerd.test.exe`, and update helper functions in `cri-containerd` to accept `tb testing.TB` instead of `t *testing.T`. Switched `cri-containerd` to `test\internal\flag` so that `test\internal\require` can be used to check if features are present since that implementation already mirrors what `cri-containerd` does, but accepts a `testing.TB`, and deleted old `test/internal/stringsetflag.go` file. Renamed `scripts/Test-Functionl.ps1` to `scripts/Run-Tests.ps1`, and updated it to run both functional and CRI tests and benchmarks. Signed-off-by: Hamza El-Saawy <[email protected]>
|
rebase to get CI fixes for failing integration testing |
katiewasnothere
approved these changes
Jan 31, 2023
Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRI API benchmarks to
cri-containerd.test.exe, and update helper functions incri-containerdto accepttb testing.TBinstead oft *testing.T.Switched
cri-containerdtotest\internal\flagso thattest\internal\requirecan be used to check if features are present since that implementation already mirrors whatcri-containerddoes, but accepts atesting.TB, and deleted oldtest/internal/stringsetflag.gofile.Renamed
scripts/Test-Functionl.ps1toscripts/Run-Tests.ps1, and updated it to run both functional and CRI tests and benchmarks.Signed-off-by: Hamza El-Saawy [email protected]