Update selectContainerFromConstraints to work on a container list #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small point of improvement that we saved away was to take a list of containers rather than constraints when selecting a container. This will make the function more usable elsewhere in tests. This change doesn't do anything but the refactoring. Future usage of the more generally useful function can be done as needed. Signed-off-by: Sean T. Allen <[email protected]>
helsaawy
approved these changes
Feb 6, 2023
anmaxvl
approved these changes
Feb 16, 2023
|
Can this get a merge? We have two approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small point of improvement that we saved away was to take a list of containers rather than constraints when selecting a container. This will make the function more usable elsewhere in tests.
This change doesn't do anything but the refactoring. Future usage of the more generally useful function can be done as needed.
Signed-off-by: Sean T. Allen [email protected]