Fix process handle leak when launching a job container #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
force-pushed
the
jc-leak
branch
2 times, most recently
from
cd17da8
to
01b53e3
Compare
msscotb
reviewed
Feb 8, 2024
CreateProcess gives us back a handle to the newly created process. Previously, we ignored this handle, which meant it was leaking every time we created a new job container (or anything else that uses internal/exec in the future). Process handle leaks can be bad as an exited process is left as a "zombie" until all handles to it have closed, continuing to use memory. Fix this by closing the handle from CreateProcess. Signed-off-by: Kevin Parsons <[email protected]>
ambarve
approved these changes
Feb 8, 2024
msscotb
approved these changes
Feb 8, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateProcess gives us back a handle to the newly created process. Previously, we ignored this handle, which meant it was leaking every time we created a new job container (or anything else that uses internal/exec in the future).
Process handle leaks can be bad as an exited process is left as a "zombie" until all handles to it have closed, continuing to use memory.
Fix this by closing the handle from CreateProcess.