Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Documentation: coding style setting with examples #471

Merged
merged 10 commits into from
Jun 25, 2021

Conversation

paryoja
Copy link
Contributor

@paryoja paryoja commented Jun 24, 2021

What is the context for this pull request?

What changes were proposed in this pull request?

Add detailed setting for scalafmt with Intellij.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not required.

@paryoja
Copy link
Contributor Author

paryoja commented Jun 24, 2021

Added guideline / sample image to reference.
I'm not sure is it sufficient.

And I added some image that might help me at the first time I started to setup my Intellij project.

@imback82 do you think it needs more details? I think Project Structure is a bit too much since it will be displayed at the front page of the github project.

@paryoja paryoja marked this pull request as ready for review June 24, 2021 06:02
Copy link
Collaborator

@sezruby sezruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sezruby sezruby requested review from clee704 and imback82 June 24, 2021 06:59
@sezruby sezruby added the documentation Improvements or additions to documentation label Jun 24, 2021
@paryoja paryoja changed the title Document/coding style Document coding style setting with example Jun 24, 2021
@paryoja paryoja changed the title Document coding style setting with example Documentation: coding style setting with examples Jun 24, 2021
docs/coding-guidelines/scala-coding-style.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sezruby sezruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @paryoja!
@clee704 @imback82 please leave any comment on this PR if you have any.

@sezruby sezruby merged commit 38bd400 into microsoft:master Jun 25, 2021
@sezruby sezruby added this to the v0.5.0 milestone Jun 29, 2021
@paryoja paryoja deleted the document/coding_style branch June 29, 2021 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants