This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Refactoring for an extensible Index API: Part 2 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2021
- Change the return type of refreshIncremental so that implementations can choose what the framework should do after the incremental refresh regarding the index data files. - Move CoveringIndex.resolveConfig to IndexUtils.resolveColumns to make it available to other index implementations.
sezruby
approved these changes
Jun 28, 2021
clee704
added
refactoring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
can choose what the framework should do after the incremental refresh
regarding the index data files.
it available to other index implementations.
Does this PR introduce any user-facing change?
No
How was this patch tested?
With existing tests