This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Case Sensitivity: Support Case Insensitive Index Column Names #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added some tests
apoorvedave1
commented
Jul 1, 2020
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
apoorvedave1
commented
Jul 1, 2020
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/IndexNameUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/IndexNameUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/IndexNameUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
and added some tests
…1 into casesensitivity
rapoth
changed the title
imback82
reviewed
Jul 15, 2020
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
pirz
reviewed
Jul 23, 2020
imback82
reviewed
Jul 25, 2020
src/test/scala/com/microsoft/hyperspace/index/rules/JoinIndexRuleTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/rules/JoinIndexRuleTest.scala
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/CreateIndexTests.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/CreateIndexTests.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/CreateIndexTests.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/E2EHyperspaceRulesTests.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/util/ResolverUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Aug 1, 2020
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
|
@apoorvedave1 Can you resolve conflicts please? |
# Conflicts: # src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
# Conflicts: # src/test/scala/com/microsoft/hyperspace/index/E2EHyperspaceRulesTests.scala
imback82
reviewed
Aug 3, 2020
src/main/scala/com/microsoft/hyperspace/index/rules/JoinIndexRule.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Aug 3, 2020
src/test/scala/com/microsoft/hyperspace/index/E2EHyperspaceRulesTests.scala
Show resolved
Hide resolved
# Conflicts: # src/test/scala/com/microsoft/hyperspace/actions/CreateActionTest.scala
imback82
previously approved these changes
Aug 4, 2020
src/test/scala/com/microsoft/hyperspace/index/E2EHyperspaceRulesTests.scala
Outdated
Show resolved
Hide resolved
imback82
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27
What changes were proposed in this pull request?
Currently index creation and usage is case sensitive. This PR addresses the issue by using "spark.sql.caseSensitivity" to determine whether to support case sensitivity or not. It adds support to use indexes if the original query is case insensitive.
Why are the changes needed?
Currently index creation and usage is case sensitive.
If base table has columns "c1", "c2" and the query is "SELECT C1, C2 FROM T WHERE...." the indexes cannot be used beause the rules do a case-sensitive matching irrespective of the value of "spark.sql.caseSensitivity".
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit tests to cover case-insensitive scenarios