Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Nullable Guid #164

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Support Nullable Guid #164

merged 1 commit into from
Oct 11, 2022

Conversation

shaopeng-gh
Copy link
Collaborator

This add feature to generate Guid? when the uuid property is not required , and Guid when it is.
Without this, for those using C# string was able to use C# null; but not now with the newly added C# Guid type.

michaelcfanning
michaelcfanning approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning merged commit 1f695c3 into main Oct 11, 2022
@shaopeng-gh shaopeng-gh mentioned this pull request Oct 11, 2022
Merged
@shaopeng-gh shaopeng-gh deleted the users/shaopeng-gh/uuidfix branch October 12, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcfanning michaelcfanning michaelcfanning approved these changes

@cfaucon cfaucon Awaiting requested review from cfaucon

@EasyRhinoMSFT EasyRhinoMSFT Awaiting requested review from EasyRhinoMSFT

@yongyan-gh yongyan-gh Awaiting requested review from yongyan-gh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaopeng-gh @michaelcfanning