bugfix/enum queryparameters serialization #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
andrueastman,
zengin,
MIchaelMainer,
ddyett and
rkodev
as code owners
andrueastman
previously approved these changes
Nov 16, 2023
baywet
force-pushed
the
bugfix/enum-queryparameters-serialization
branch
from
25e0f3c
to
18d4202
Compare
|
@rkodev this is ready for review now |
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Nov 21, 2023
|
Super interesting to see this solution, as it's pretty close to what @lburgazzoli suggested as well for std-uritemplate, I think it makes sense here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related microsoft/kiota#3693
depends on std-uritemplate/std-uritemplate#92