Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL support #3012

Merged
merged 7 commits into from
Oct 23, 2023
Merged

WSL support #3012

merged 7 commits into from
Oct 23, 2023

Conversation

squirrelsc
Copy link
Member

@squirrelsc squirrelsc commented Oct 17, 2023

It needs to rebase to previous PR to reduce commits. The work is tested with local and Azure platforms. I will add document later.

See details in commits and document.

@squirrelsc squirrelsc force-pushed the 1002_wsl branch 5 times, most recently from c57e0cd to b86e306 Compare October 18, 2023 16:43
@squirrelsc squirrelsc marked this pull request as ready for review October 18, 2023 16:44
@squirrelsc
Copy link
Member Author

@LiliDeng it's ready for reviewing

lisa/tools/wsl.py Outdated Show resolved Hide resolved
lisa/tools/wsl.py Outdated Show resolved Hide resolved
lisa/tools/wsl.py Outdated Show resolved Hide resolved
@LiliDeng
Copy link
Collaborator

I have tested it against azure and libvirt platform to confirm there is no regression bring in. And I may post some stupid comments/questions, since I don't know the WSL testing in lisa deeply.

@squirrelsc
Copy link
Member Author

I have tested it against azure and libvirt platform to confirm there is no regression bring in. And I may post some stupid comments/questions, since I don't know the WSL testing in lisa deeply.

Thank you, Lili! All comments are valuable. Any existing tests should be able to run with WSL node ideally, but we are focusing on single node tests. There must be some test cases are not supported, like if the features are used.

I will fix LTP data disk dependency. In the mean time, you can test with cpu or other simple test cases.

@LiliDeng
Copy link
Collaborator

LiliDeng commented Oct 19, 2023

I have tested it against azure and libvirt platform to confirm there is no regression bring in. And I may post some stupid comments/questions, since I don't know the WSL testing in lisa deeply.

Thank you, Lili! All comments are valuable. Any existing tests should be able to run with WSL node ideally, but we are focusing on single node tests. There must be some test cases are not supported, like if the features are used.

I will fix LTP data disk dependency. In the mean time, you can test with cpu or other simple test cases.

I test it in azure platform with image MicrosoftWindowsServer WindowsServer 2022-datacenter latest
And encounter the issue mentioned here

this approach works (I didn't try the other approaches)

wsl --set-default-version 1
wsl.exe --install Ubuntu
wsl --set-default-version 2

If azure vm with NestedVirtualization feature, current code works perfectly.

@squirrelsc
Copy link
Member Author

I have tested it against azure and libvirt platform to confirm there is no regression bring in. And I may post some stupid comments/questions, since I don't know the WSL testing in lisa deeply.

Thank you, Lili! All comments are valuable. Any existing tests should be able to run with WSL node ideally, but we are focusing on single node tests. There must be some test cases are not supported, like if the features are used.
I will fix LTP data disk dependency. In the mean time, you can test with cpu or other simple test cases.

I test it in azure platform with image MicrosoftWindowsServer WindowsServer 2022-datacenter latest And encounter the issue mentioned here

this approach works (I didn't try the other approaches)

wsl --set-default-version 1 wsl.exe --install Ubuntu wsl --set-default-version 2

If azure vm with NestedVirtualization feature, current code works perfectly.

Yes, forget to mention, it needs nested virtualization vm sizes.

@squirrelsc
Copy link
Member Author

@LiliDeng It's ready to me. Please merge it after next release.

@LiliDeng LiliDeng merged commit b7991a8 into microsoft:main Oct 23, 2023
23 checks passed
@squirrelsc squirrelsc deleted the 1002_wsl branch October 23, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants