Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfoBar icon theming incorrect #3581

Closed
gabbybilka opened this issue Nov 9, 2020 · 1 comment · Fixed by #3603
Closed

InfoBar icon theming incorrect #3581

gabbybilka opened this issue Nov 9, 2020 · 1 comment · Fixed by #3603
Labels
area-InfoBar team-Controls Issue for the Controls team
Milestone
WinUI 2.5

Comments

@gabbybilka
Copy link
Member

Describe the bug
infobar-icon

The icon foreground color does not react to theme change, it should be white instead of black.

Reproduce the bug
The XCG generated with the 2.5 prerelease.201027002 package at user/gabilka/InfoBar in the XCG repo shows this bug on theme change from light to dark.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 9, 2020
@mdtauk
Copy link
Contributor

mdtauk commented Nov 9, 2020

Switch to using ThemeResource Brushes

@ranjeshj ranjeshj added area-InfoBar team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels Nov 10, 2020
@ranjeshj ranjeshj added this to the WinUI 2.5 milestone Nov 10, 2020
@ranjeshj ranjeshj removed the help wanted Issue ideal for external contributors label Nov 12, 2020
@ranjeshj ranjeshj mentioned this issue Nov 12, 2020
Merged
@ghost ghost added the working on it label Nov 12, 2020
@dpaulino dpaulino mentioned this issue Nov 14, 2020
Open
@ghost ghost removed the working on it label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-InfoBar team-Controls Issue for the Controls team
Projects
None yet
Milestone
WinUI 2.5
Development

Successfully merging a pull request may close this issue.

Switch to using ThemeResource for icon in InfoBar microsoft/microsoft-ui-xaml
3 participants
@mdtauk @gabbybilka @ranjeshj