Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: LoginDialog Control #799

Open
shaggygi opened this issue Jun 4, 2019 · 6 comments
Open

Proposal: LoginDialog Control #799

shaggygi opened this issue Jun 4, 2019 · 6 comments
Labels
area-Dialogs feature proposal New feature proposal proposal-NewControl This proposal might involve creating a new control team-Controls Issue for the Controls team

Comments

@shaggygi
Copy link

shaggygi commented Jun 4, 2019

Proposal: Add LoginDialog Control

Similar to #792, it would be nice to have a LoginDialog control similar to MahApps LoginDiagram for user to enter user/pass.

Summary

While devs can create their own, it is a little more complex as the PasswordBox control is harder to setup for MVVM binding due to security issues.

Instead of creating custom logic/UI, it would be nice to have a native control to perform basic login UI.

@shaggygi shaggygi added the feature proposal New feature proposal label Jun 4, 2019
@YuliKl YuliKl self-assigned this Jun 4, 2019
@YuliKl
Copy link

YuliKl commented Jun 4, 2019

@shaggygi, thank you for the proposal and, again, more detail would be great. Would the only purpose of this control to enable users to enter their username/password while supporting MVVM, or would you want to see other scenarios covered?

@shaggygi
Copy link
Author

shaggygi commented Jun 4, 2019

@YuliKl Thanks for the reply. My initial thought it would purely for 1) MVVM support and 2) allow user to enter username/password. One disadvantage of only this is it would have to return back to caller to perform the verification. If the username/password failed, the dialog would have to be called again to inform user of error and retry.

I guess you could pass an authentication interface, but gets complicated as that would be known and if it would work for different scenarios.

In the end, I could get around this and create my own ContentDialog for this. However, it is the security and support for MVVM around the PasswordBox that would be good instead of coding.

@mrlacey
Copy link
Contributor

mrlacey commented Jun 5, 2019

This would be much easier to implement once #179 (native Input validation) is part of the platform.
However, I'd be very cautious about providing such a control as it is likely that once an "official" login control is available it can be tempting for developers to use this as an excuse to delegate some of their responsibility for managing security and passwords appropriately. As this could easily lead to the production of less secure software careful consideration of this must be taken.

@YuliKl
Copy link

YuliKl commented Jun 5, 2019

Thank you for your cautionary comment, @mrlacey! While a login dialog seems useful, I can definitely imagine a control like this turning into a crutch.

While we definitely won't be able to act on this proposal until after WinUI 3.0 ships, I would like to keep this issue in our "freezer" to be considered in the future.

@YuliKl YuliKl removed their assignment Jun 5, 2019
@mrlacey
Copy link
Contributor

mrlacey commented Jun 5, 2019

@YuliKl I understand keeping it open ;)
We still have a similar issue open for Windows Template Studio but I've very reluctant to actually implement it and we are instead focusing authentication efforts in WTS around web/MSAL based auth for now to avoid some of the potential issues here.

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@ranjeshj ranjeshj added the proposal-NewControl This proposal might involve creating a new control label Apr 13, 2020
@sigmarsson
Copy link

Perhaps #4374 would facilitate to deal with credential providers and free you up from dealing with passwords ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs feature proposal New feature proposal proposal-NewControl This proposal might involve creating a new control team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

6 participants