Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: ProgressDialog Control #792

Closed
shaggygi opened this issue Jun 3, 2019 · 7 comments
Closed

Proposal: ProgressDialog Control #792

shaggygi opened this issue Jun 3, 2019 · 7 comments
Assignees
Labels
area-Dialogs feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@shaggygi
Copy link

shaggygi commented Jun 3, 2019

Proposal: Add ProgressDialog Control

Would be nice to have control similar to MahApps ProgressDialog. See link below for details.

https://github.com/MahApps/MahApps.Metro/blob/develop/src/MahApps.Metro/Controls/Dialogs/ProgressDialog.xaml

Summary

Instead of creating custom logic/UI, it would be nice to have a native control to perform basic progress UI and updates.

@YuliKl
Copy link

YuliKl commented Jun 4, 2019

Hi @shaggygi, thank you for the proposal. Can you elaborate a bit on what you're looking for? Is a ProgressBar sufficient for the "basic progress UI" requirement? What kind of updates would you expect the control to handle?

@mdtauk
Copy link
Contributor

mdtauk commented Jun 4, 2019

I know with Windows phone, WinRT, and UWP apps, the general thinking is not to block the UI thread, and to keep progress bars for actions in the app, and allow the user to continue using the app.

A ProgressDialog seems like it would be modal, and stop the app being used whilst progress continues.

You could also use a ContentDialog with a progress bar and message on it, but that requires wiring up the logic yourself.

What if you could add ContentDialogs to the app, via File > New Item, and there were templates or boilerplate options, without making specific controls for Progress and Login UX?

@shaggygi
Copy link
Author

shaggygi commented Jun 4, 2019

@YuliKl Thanks for reply. The ProgressDialog is a bit more as it provides a dialog to up UI with things such as text along with a ProgressBar. You can see an example of the ProgressDialog here.

@mdtauk MahApps also provides a ProgressDialogController where it allows the main app (or parent window) to communicate to the ProgressDialog along with canceling if needed.

@YuliKl
Copy link

YuliKl commented Jun 5, 2019

@shaggygi, I think what you're proposing is already relatively straight-forward to create using a ContentDialog. Yes, every app that wanted to show a progress dialog would need to set more than just a string as ContentDialog's content, but the work required is pretty straightforward.

Given our roadmap, I don't think we can prioritize spending time implementing a feature that is already enabled.

@shaggygi
Copy link
Author

shaggygi commented Jun 5, 2019

@YuliKl Understood. Thanks for taking some time to review. I'll go ahead and close for now.

@shaggygi shaggygi closed this as completed Jun 5, 2019
@YuliKl
Copy link

YuliKl commented Jun 5, 2019

What if you could add ContentDialogs to the app, via File > New Item, and there were templates or boilerplate options, without making specific controls for Progress and Login UX?

You can already add ContentDialog as a new item.
image

As far as specific templates, that seems like a great suggestion for https://github.com/microsoft/WindowsTemplateStudio

@mdtauk
Copy link
Contributor

mdtauk commented Jun 5, 2019

What if you could add ContentDialogs to the app, via File > New Item, and there were templates or boilerplate options, without making specific controls for Progress and Login UX?

You can already add ContentDialog as a new item.
image

As far as specific templates, that seems like a great suggestion for https://github.com/microsoft/WindowsTemplateStudio

My comment was about providing different ContentDialogs with the code and UI for making a Progress Dialog, or a Login Dialog - and the developer can then wire it all up.

But I still think displaying a dialog which locks the app while progress is made is not ideal for modern apps.

Windows Phone used to provide a system progress bar in the Status Bar which would display without locking the app.

image

Perhaps something like this should be the guidance for displaying progress of a recently invoked action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants